[CLJ-1313] Correct a few unit tests Created: 23/Dec/13 Updated: 17/Jul/15 Resolved: 17/Jul/15
|Affects Version/s:||Release 1.5, Release 1.6|
|Fix Version/s:||Release 1.8|
|Attachments:||clj-1313-v1.diff clj-1313-v2.diff clj-1313-v3.patch|
|Patch:||Code and Test|
Several unit tests do not test what they appear to have been intended to test, because of missing is statements around (= expr1 expr2) expressions, or because of use of (is (thrown? ...)) instead of (is (thrown-with-msg? ...))
Screened by: Alex Miller
|Comment by Andy Fingerhut [ 23/Dec/13 3:11 AM ]|
Patch clj-1313-v1.diff wraps (is ...) around several = expressions in unit tests that appeared to have been missing them, and changes several thrown? to thrown-with-msg? when there were regexes that were unused.
|Comment by Stuart Halloway [ 31/Jan/14 12:36 PM ]|
please update to apply cleanly on master
|Comment by Andy Fingerhut [ 31/Jan/14 3:29 PM ]|
clj-1313-v2.diff is identical to clj-1313-v1.diff except that it removes the portion that conflicts with the latest Clojure master. That portion needs updating for a different reason anyway (ticket
|Comment by Andy Fingerhut [ 04/Apr/15 1:36 PM ]|
clj-1313-v3.patch adds two other test corrections/improvements that were not in the -v2 patch. The change from doall to dorun is not really a correction, as much as cleaning up the fact that the return value of doall was discarded.