[CLJ-1380] Three-arg ExceptionInfo constructor permits nil data Created: 13/Mar/14 Updated: 01/Oct/14
|Affects Version/s:||Release 1.5|
|Patch:||Code and Test|
The argument check in the two-arg clojure.lang.ExceptionInfo constructor isn't present in the three-arg constructor so it's possible to create an ExceptionInfo with arbitrary (or nil) data.
|Comment by Gordon Syme [ 13/Mar/14 10:47 AM ]|
Sorry, didn't meant to classify as "major" and I don't have permissions to edit.
|Comment by Gordon Syme [ 13/Mar/14 11:11 AM ]|
Patch + tests
I'm not at all familiar with the project so may have put tests in the wrong language and/or wrong place.
The ex-info-works test is a bit dorky but shows that both constructors are equivalent (and passes without the patch to ExceptionInfo).
|Comment by Alex Miller [ 13/Mar/14 12:18 PM ]|
No worries on the classification - I adjust most incoming tickets in some way or another.
Thanks for the patch, however it cannot be considered unless you complete the Clojure Contributor's Agreement - http://clojure.org/contributing. This is an important step in the process that keeps the Clojure codebase on a sound legal basis.
Someone else could develop a clean room patch implementation for this ticket later, but of course it would be ideal if you could become a contributor!
|Comment by Gordon Syme [ 13/Mar/14 1:15 PM ]|
sure, that makes sense. I'll get the contributor's agreement in the post. It may take a while to arrive since I'm based in Europe.
|Comment by Gordon Syme [ 25/Mar/14 10:03 AM ]|
I just checked http://clojure.org/contributing, looks like my CCA made it through
|Comment by Andy Fingerhut [ 01/Oct/14 6:48 PM ]|
Gordon, I do not know if your patch is of interest to the Clojure developers, so I can't comment on that aspect of this ticket.
Instructions for creating a patch in the expected format is given on the wiki page below. Your patch is not in the expected format.