0001-Added-ClosableResource-protocol-for-with-open.patch
[CLJ-308] protocol-ize with-open Created: 21/Apr/10 Updated: 13/Apr/12 |
|
| Status: | Open |
| Project: | Clojure |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Backlog |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Anonymous | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 3 |
| Labels: | None | ||
| Attachments: |
0001-Added-ClosableResource-protocol-for-with-open.patch
|
| Patch: | Code |
| Description |
|
Good use (and documentation example) of protocols: make with-open aware of a Closable protocol for APIs that use a different close convention. See http://groups.google.com/group/clojure/browse_thread/thread/86c87e1fc4b1347c |
| Comments |
| Comment by Assembla Importer [ 24/Aug/10 4:39 PM ] |
|
Converted from http://www.assembla.com/spaces/clojure/tickets/308 |
| Comment by Tassilo Horn [ 23/Dec/11 5:11 AM ] |
|
Added a CloseableResource protocol and extended it on java.io.Closeable (implemented by all Readers, Writers, Streams, Channels, Sockets). Use it in with-open. All tests pass. |
| Comment by Tassilo Horn [ 23/Dec/11 7:14 AM ] |
|
Seems to be related to Scopes (http://dev.clojure.org/jira/browse/CLJ-2). |
| Comment by Tassilo Horn [ 08/Mar/12 3:59 AM ] |
|
Updated patch. |
| Comment by Andy Fingerhut [ 02/Apr/12 12:11 PM ] |
|
Patch 0001-Added-ClosableResource-protocol-for-with-open.patch dated 08/Mar/12 applies, builds, and tests cleanly on latest master as of Apr 2 2012. Tassilo has signed a CA. |
| Comment by Tassilo Horn [ 13/Apr/12 11:23 AM ] |
|
Updated patch to apply cleanly against master again. |