[CLJ-433] munge should not munge $ (which isJavaIdentifierPart), should munge ' (which is not) Created: 09/Sep/10 Updated: 01/Mar/13 Resolved: 05/Jan/11
|Fix Version/s:||Release 1.3|
munge is overeager in converting $ to DOLLARSIGN, since $ is a valid
On a related point, ' (single quote) is not admissible in Java
This leads to e.g.
(note the ' after STAR).
Originally reported on the Dev list.
See also this thread on the (regular) Clojure ggroup.
The attached patch applies cleanly against current master.
|Comment by Assembla Importer [ 28/Sep/10 4:32 PM ]|
Converted from http://www.assembla.com/spaces/clojure/tickets/433
|Comment by Stuart Halloway [ 30/Oct/10 12:12 PM ]|
Patch is clean, the real issue here is doing the right thing. Two concerns:
|Comment by Rich Hickey [ 05/Nov/10 8:00 AM ]|
This issue mentions two problems but patch fixes only one. Should add the single-quote handling
|Comment by Michał Marczyk [ 08/Dec/10 12:12 AM ]|
Right, I forgot about that in the patch somehow. Also, I just noticed that " is also not JavaIdentifierPart and yet is not currently munged. The newly attached patch fixes all three issues.