<< Back to previous view

[CLJ-8] GC Issue 3: Re-enable detection of circular loads Created: 17/Jun/09  Updated: 28/Jan/11  Resolved: 28/Jan/11

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.3

Type: Enhancement Priority: Minor
Reporter: Stephen C. Gilardi Assignee: Stephen C. Gilardi
Resolution: Completed Votes: 2
Labels: None

Attachments: Text File 0008-cyclic-deps-resolved.patch    
Patch: Code and Test
Approval: Ok

 Description   
Reported by richhickey, Dec 17, 2008
Was made a no-op for AOT/gen-class - need to distinguish cases

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: ---
Comment 2 by richhickey, Dec 18, 2008
(No comment was entered for this change.)
Labels: Priority-High
Comment 3 by scgilardi, May 12, 2009
Rich, do you have an example of the problem with AOT/gen-class that motivated
disabling detection of circular loads? With that in hand, I'd like to take a look at
fixing this.
Comment 4 by richhickey, May 13, 2009
You should just try it out. I'm not sure if it is just something I encountered on my
way to the final mechanism (and now isn't needed). However, you should hold off right
at the moment, as I'm working on loading/classloader stuff.


 Comments   
Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/8
Attachments:
load-tracking.diff - https://www.assembla.com/spaces/clojure/documents/arZXq-2qKr3R8teJe5aVNr/download/arZXq-2qKr3R8teJe5aVNr
check-cyclic-load.diff - https://www.assembla.com/spaces/clojure/documents/aUykkoZfSr35wNeJe5cbCb/download/aUykkoZfSr35wNeJe5cbCb

Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)

Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

scgilardi said: I'm working on this now. I plan to have more info by 19 October.

Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

richhickey said: Updating tickets (#8, #42, #113, #2, #20, #94, #96, #104, #119, #124, #127, #149, #162)

Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

scgilardi said: [file:arZXq-2qKr3R8teJe5aVNr]: fixes tickets 8, 42, and 113

Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

scgilardi said: please see my posting to the developer group

Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

scgilardi said: [file:aUykkoZfSr35wNeJe5cbCb]: patch to detect/reject cyclic deps

Comment by Assembla Importer [ 30/Sep/10 2:42 PM ]

scgilardi said: fresh patch that detects and rejects cyclic dependencies. based on today's master. tests included.

Comment by Stephen C. Gilardi [ 07/Jan/11 1:31 PM ]

I provided a patch for this. Is there anything further I can or must do to to move it along?

Comment by Stuart Halloway [ 15/Jan/11 3:50 PM ]

Had to recreate the patch almost from scratch. Haven't seen this problem before--when the git merge failed, it wouldn't create any .rej files to work with.

Recreated patch is same as Steve's, except for a test configuration change to match current MASTER.

Generated at Thu Oct 23 06:45:29 CDT 2014 using JIRA 4.4#649-r158309.