[CLJ-952] bigdec does not properly convert a clojure.lang.BigInt Created: 12/Mar/12 Updated: 18/May/12 Resolved: 18/May/12
|Affects Version/s:||Release 1.3, Release 1.4|
|Fix Version/s:||Release 1.5|
|Patch:||Code and Test|
bigdec handles java.math.BigInteger when converting to java.math.BigDecimal, but it does not handle clojure.lang.BigInt. Instead it treats a clojure.lang.BigInt as a Number, by casting it to long. This causes the following error:
|Comment by Andy Fingerhut [ 21/Mar/12 10:55 AM ]|
Add a case to bigdec to handle BigInts. Also eliminate a reflection warning in the ratio case while we are in there. Paul's failing case has been added to tests, fails before the fix, and passes after. Attempted to make it as run-time efficient as possible by creating a new BigInt/toBigDecimal, patterned after the existing BigInt/toBigInteger.
|Comment by Paul Stadig [ 21/Mar/12 11:51 AM ]|
I was originally thinking of something like (BigDecimal. (.toBigInteger ^clojure.lang.BigInt x)). Adding a toBigDecimal method to clojure.lang.BigInt saves some object allocations and such. Probably more of a micro optimization, but it works.
|Comment by Alan Dipert [ 20/Apr/12 1:35 PM ]|
Looks good to me, thanks.