<< Back to previous view

[CLJ-954] TAP Support in clojure.test.tap Needs Updating Created: 15/Mar/12  Updated: 18/May/12  Resolved: 18/May/12

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: Release 1.3, Release 1.4
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Daniel Gregoire Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Attachments: File fix-tap-test-runner.diff    
Patch: Code
Approval: Ok

 Description   

The testing-vars-str function requires one argument, but in the clojure.test.tap namespace it is currently called with zero arguments. This results in a clojure.lang.ArityException when attempting to generate TAP output with with-tap-out.

Here are links to the occurrences of this in the latest commit to clojure.test.tap:

1. https://github.com/clojure/clojure/blob/36642c984cbf52456e45a8af0a96e4b7e7417041/src/clj/clojure/test/tap.clj#L81
2. https://github.com/clojure/clojure/blob/36642c984cbf52456e45a8af0a96e4b7e7417041/src/clj/clojure/test/tap.clj#L92

After fixing this particular issue in my local copy of 1.4.0-SNAPSHOT, there appear to be other problems with this code as well (e.g., not producing correct output for failing tests). Since this code appears to be unmaintained and untested, perhaps it should live outside the main Clojure repo?



 Comments   
Comment by John Szakmeister [ 15/Apr/12 6:45 PM ]

This fixes all the known issues with the tap test runner.

Generated at Thu Oct 23 10:15:37 CDT 2014 using JIRA 4.4#649-r158309.