[CLJ-961] with-redefs loses a Var's root binding if the Var is thread-bound Created: 28/Mar/12 Updated: 20/Jul/12 Resolved: 20/Jul/12
|Affects Version/s:||Release 1.3|
|Reporter:||Jiří Maršík||Assignee:||Rich Hickey|
|Patch:||Code and Test|
When a Var has an in-thread binding and I use with-redefs to temporarily alter its root binding, the value restored to the root binding after with-redefs is finished will not be the original root value, but the thread-local one. The problem is using deref instead of something like clojure.lang.Var's .getRawRoot to backup the original root values in with-derefs-fn.
I have never used with-redefs and it is very unlikely that one would use it while the Vars in question are thread-bound. However, when reading the function's definition in Joy of Clojure and later in core.clj, I did not believe this behaviour was intended.
|Comment by Aaron Bedra [ 10/Jul/12 6:53 PM ]|
I paired with Gary on this and tested the patch on my machine after it was uploaded.