js-obj-fn.patch
[CLJS-215] js-obj function broken Created: 29/Apr/12 Updated: 29/Apr/12 Resolved: 29/Apr/12 |
|
| Status: | Resolved |
| Project: | ClojureScript |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Major |
| Reporter: | Brandon Bloom | Assignee: | Unassigned |
| Resolution: | Completed | Votes: | 0 |
| Labels: | patch, | ||
| Attachments: |
js-obj-fn.patch
|
| Patch: | Code and Test |
| Description |
|
The js-obj macro is fine, but the js-obj function was incorrectly using "{foo: bar}" expecting "foo" to be evaluated as a variable, instead of as a string key. Since we have the js-obj macro for speed, I just deleted the broken overloads, so now all the non-zero arity cases simply call gobject |
| Comments |
| Comment by David Nolen [ 29/Apr/12 5:08 PM ] |
|
fixed, https://github.com/clojure/clojurescript/commit/f4a3ef43dc70aed4f15045836d709989a95ef6f7 |