[CLJS-304] Comparing a js/Date to nil throws Created: 05/Jun/12 Updated: 18/Jun/12 Resolved: 18/Jun/12 |
|
| Status: | Resolved |
| Project: | ClojureScript |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Minor |
| Reporter: | Brandon Bloom | Assignee: | Unassigned |
| Resolution: | Completed | Votes: | 0 |
| Labels: | patch, patch, | ||
| Attachments: |
date-equiv2.patch
date-equiv3.patch
date-equiv.patch
|
| Patch: | Code |
| Description |
|
(= (js/Date.) nil) |
| Comments |
| Comment by Brandon Bloom [ 05/Jun/12 10:27 PM ] |
|
D'oh! Sorry, this patch causes a warning: WARNING: Use of undeclared Var cljs.core/instance? at line 384 |
| Comment by David Nolen [ 17/Jun/12 12:06 PM ] |
|
updated patch please. |
| Comment by Brandon Bloom [ 17/Jun/12 4:28 PM ] |
|
Sorry, forgot about this ticket. Attached patch has two additional commits: 1st stops calling .getTime with list/EMPTY via unecessary '() and the 2nd moves instance? from the "preds" to "fundamentals" section of core.cljs. |
| Comment by David Nolen [ 18/Jun/12 9:01 AM ] |
|
Thanks can we collapse the patch into one commit? |
| Comment by Brandon Bloom [ 18/Jun/12 4:45 PM ] |
|
Same as patch 2 with commits squashed |
| Comment by David Nolen [ 18/Jun/12 8:59 PM ] |
|
fixed, http://github.com/clojure/clojurescript/commit/80726438d7375eb72cd4ea82a7ea676d3237b6ce |