[CLJS-407] cljs.import-test not run in test suite / ordering problem in the compiler Created: 24/Oct/12 Updated: 21/Dec/12
The test code from
Hooking up the test, however reveals a deeper problem (besides that it has a failing assumption):
Presumably due to the goog.provides later in the files, the compiler orders the output wrong, which results in not provided errors.
|Comment by Herwig Hochleitner [ 24/Oct/12 3:23 AM ]|
Patch hooks up the tests into the test suite.
If you want to see the provide error, delete out before compiling.
If you want to see the failing assertion from the original test, compile a second time.
|Comment by David Nolen [ 24/Oct/12 11:01 AM ]|
In order to better understand tickets it best not to complect different issues If there's a problem not addressed by the patch please mention that in another ticket (and feel to reference that one here).
I assume the patch fixes one thing, but reveals an unresolved issue, am I correct?
|Comment by Herwig Hochleitner [ 24/Oct/12 11:26 AM ]|
You're right, the ordering problem could be a different ticket. Sorry for that.
To clarify, there are three issues at play:
1) Part of the testsuite not executed (fixed by the patch)
The reason I decided to roll it into one ticket is that only addressing one of 2) and 3) leaves the test suite failing. I almost wanted to reopen
|Comment by David Nolen [ 21/Dec/12 6:07 PM ]|
I fixed some dependency ordering issue in another patch, would be nice to know if the ordering issues are addressed. What part of this ticket is still relevant? This is why tickets that only address one thing at a time are nice