cljs-print-record-with-namespace.patch
[CLJS-466] Records are printed without namespace Created: 05/Feb/13 Updated: 26/Feb/13 Resolved: 26/Feb/13 |
|
| Status: | Resolved |
| Project: | ClojureScript |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Major |
| Reporter: | Thomas Heller | Assignee: | Unassigned |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Any |
||
| Attachments: |
cljs-print-record-with-namespace.patch
|
| Patch: | Code and Test |
| Description |
|
When printing a Record it is currently printed without the proper namespace. (ns dummy) will print as "#dummy.Foo{..." in CLJ but "#Foo{..." in CLJS. The attached patch fixes the implementation as well as the "incorrect" test. |
| Comments |
| Comment by David Nolen [ 06/Feb/13 11:39 AM ] |
|
Thanks, have you submitted your CA? |
| Comment by Thomas Heller [ 06/Feb/13 3:57 PM ] |
|
Will do ASAP, I'm in Germany so its probably gonna take a week or so. |
| Comment by David Nolen [ 26/Feb/13 10:52 AM ] |
|
This patch was not properly created. Please follow the example demonstrated here - http://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git |
| Comment by Thomas Heller [ 26/Feb/13 12:14 PM ] |
|
Patch updated. I sent me CA over 2 weeks ago, should I assume it was lost and try again or does it usually take this long? |
| Comment by David Nolen [ 26/Feb/13 12:18 PM ] |
|
Fixed, http://github.com/clojure/clojurescript/commit/8aa0cd7a0ba3f8466fcde83558ce83f275b61b32 It looks like your CA made it just fine, thank you very much for the contribution! |
| Comment by Thomas Heller [ 26/Feb/13 12:23 PM ] |
|
Ah, awesome. Thanks. |
