<< Back to previous view

[CLJS-490] cljs.closure/get-upstream-deps* should use RT/baseLoader instead of the TCCL Created: 25/Mar/13  Updated: 18/Nov/13  Resolved: 18/Nov/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Toby Crawley Assignee: Unassigned
Resolution: Declined Votes: 0
Labels: None

Attachments: File 2013-02-25-closure-RT-baseloader.diff    

 Description   

get-upstream-deps* currently uses the context classloader for the current thread, which causes issues when called from within a clojure runtime that has the intended classloader bound to Compiler.LOADER. Is there a specific reason to use the TCCL directly, or would calling RT.baseLoader suffice here? I'm attaching a patch that uses baseLoader instead.



 Comments   
Comment by Toby Crawley [ 25/Mar/13 10:12 AM ]

On further examination, this change may not make sense. Clojure itself uses the TCCL directly and ignores baseLoader when locating resources.

Generated at Wed Jul 23 19:28:02 CDT 2014 using JIRA 4.4#649-r158309.