<< Back to previous view

[CLJS-577] Misleading message when calling a multi method resulting in a miss Created: 27/Aug/13  Updated: 07/Oct/13  Resolved: 07/Oct/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Trivial
Reporter: Julien Eluard Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Attachments: File better-dispatch-error-message.diff    

 Description   

When calling a multimethod with no method matching the dispatching value an exception with a misleading message is thrown.
This is due to the usage of a name argument not part of the associated method definition, resulting to the code of cljs.core/name to be printed instead.

Provided patches fixes this by specifying the name argument.



 Comments   
Comment by Julien Eluard [ 05/Oct/13 7:32 PM ]

It looks like this patch would be a quick win. Anything I can do to help move it forward?

Comment by David Nolen [ 07/Oct/13 7:58 PM ]

fixed, http://github.com/clojure/clojurescript/commit/56848c757fe1ae1dc6f3c5a2ad7eb9ea500ebdad

Comment by David Nolen [ 07/Oct/13 8:06 PM ]

In future it's nice to have the ticket number in the description of the patch so when cutting releases it's easier to browse the commit history for figuring which bugs got squashed.

Thanks again!

Generated at Thu Aug 28 10:14:58 CDT 2014 using JIRA 4.4#649-r158309.