<< Back to previous view

[CLJS-599] (keyword :x) produces ::x Created: 26/Sep/13  Updated: 26/Sep/13  Resolved: 26/Sep/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Joel Holdbrooks Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File cljs_599.patch    
Patch: Code and Test

 Description   

I encountered this bug via a macro with (map keyword syms). (keyword :x) produces ::x, (keyword (keyword :x)) produces :::x, etc. Also, it might be worth mentioning (identical? :x (keyword :x)) and (identical? :x (keyword "x")) both fail.



 Comments   
Comment by Joel Holdbrooks [ 26/Sep/13 5:28 AM ]

I should point out this patch resolves the issue with (identical? :x (keyword :x)) but not (identical? :x (keyword "x")).

Comment by Ben Moss [ 26/Sep/13 8:34 AM ]

Seems like this was introduced with https://github.com/clojure/clojurescript/commit/2cef52840fcd9d88f077d374cc81e50c7e645b9f. Previously the `keyword` function would do what is done in the patch.

Comment by David Nolen [ 26/Sep/13 9:47 AM ]

Thanks for the report! In order to take patches we need contributors to fill out and submit a CA. http://clojure.org/contributing

Comment by David Nolen [ 26/Sep/13 9:48 AM ]

fixed http://github.com/clojure/clojurescript/commit/efb3718a602a99f9fe36e518c64968b4a80f8ca2

Comment by Joel Holdbrooks [ 26/Sep/13 12:58 PM ]

Thanks David! Looks like I've gotta get something in the mail!

Generated at Wed Apr 16 17:08:40 CDT 2014 using JIRA 4.4#649-r158309.