<< Back to previous view

[CLJS-630] Old-style property accessor raises warning on compile Created: 19/Oct/13  Updated: 24/Oct/13  Resolved: 24/Oct/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Sean Grove Assignee: Sean Grove
Resolution: Completed Votes: 0
Labels: cljs
Environment:

cljs


Attachments: Text File fix-clojure-browser-repl-property-accessor.patch     Text File fix-various-property-accessor.patch    
Patch: Code

 Description   

clojure.browser.repl is accessing the property of an event via the / syntax, which seems to have been deprecated:
https://github.com/clojure/clojurescript/blob/f74b50967ef4041db585bd6c6f2f490285f61961/src/cljs/clojure/browser/repl.cljs#L71

It causes warnings on compile:

WARNING: No such namespace: e at line 71 resources/public/js/bin-debug/clojure/browser/repl.cljs

Attached is a fix



 Comments   
Comment by Greg Chapman [ 19/Oct/13 3:25 PM ]

e/currentTarget also appears inside the clojure.reflect module (reflect.cljs, line 19 - where e is again an event object). Presumably this should also be changed if this style of property access has been deprecated.

Comment by Sean Grove [ 20/Oct/13 5:27 PM ]

Updates another e/currentTarget instance as pointed out by Greg Chapman.

Comment by David Nolen [ 24/Oct/13 9:01 AM ]

fixed, https://github.com/clojure/clojurescript/commit/2ce425abccd83887001c056e962aadb89683a86b https://github.com/clojure/clojurescript/commit/d31b5365bef4423e59f8112657a0c2402e254195

Generated at Tue Sep 02 22:02:08 CDT 2014 using JIRA 4.4#649-r158309.