[CLJS-694] Dependency on Java 7 introduced by patch for CLJS-674 Created: 21/Nov/13 Updated: 22/Nov/13 Resolved: 22/Nov/13
I introduced a call to .toPath, which is defined in Java 7. Need to refactor to avoid this so we can support down to Java 6.
|Comment by Tim Visher [ 21/Nov/13 10:47 AM ]|
fix-694.patch @ 21/NOV/13
I'm using URI's for relativizing and basic string comparison for directory comparison. URIs have a bug where they can't produce ../../ style relative paths, but since we require that your :output-dir be in the same directory as :source-map, this shouldn't bite us.
Can someone (David Powell?) who has easy access to Java 6 test this?
All tests pass.
|Comment by Tim Visher [ 21/Nov/13 3:31 PM ]|
I was able to get 1.6 installed:
And run the test prior to my patch:
and after the patch:
|Comment by David Nolen [ 21/Nov/13 3:38 PM ]|
|Comment by David Powell [ 22/Nov/13 12:58 AM ]|
Prior to this patch, I have seen cljsbuild emit sourcemaps that refer to files from the /target directory, which if you set :output-dir to "out", is going to require an implementation of relativize() that is able to emit paths starting with ../target
So I'm not sure if something wrong is happening there? I'll have to check that again once the rest of my windows issues are sorted.
I'm still looking at
|Comment by Tim Visher [ 22/Nov/13 6:09 AM ]|
@David Powell: After
|Comment by David Nolen [ 22/Nov/13 7:39 AM ]|