<< Back to previous view

[CLJS-714] cljs.closure/source-on-disk inconsistency Created: 05/Dec/13  Updated: 05/Dec/13  Resolved: 05/Dec/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Thomas Heller Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None
Environment:

clojurescript with source maps


Attachments: Text File cljs-fix-source-url-reference.patch    
Patch: Code

 Description   

cljs.closure/source-on-disk will ensure that all source files are available when source maps are enabled. Sources from jar files are copied and reference the target location afterwards, sources on the filesystem are copied BUT the reference to that location is lost.

The attached patch ensures that the correct url is used in cljs.closure/output-unoptimized since otherwise the source maps will contain links to invalid files, assuming the source files are not on :source-map-path.



 Comments   
Comment by Thomas Heller [ 05/Dec/13 5:57 AM ]

Oops this breaks some other cases, working on a fix.

Comment by Thomas Heller [ 05/Dec/13 6:15 AM ]

Ok the issue is a lot more involved than I had hoped but I uncovered a bug while looking into it. Basically CLJS expects javascript files in jars never to change, it at least wont try to copy it again so the source map might be incorrect if a javascript file inside a jar changes.

Generated at Sat Nov 22 15:43:21 CST 2014 using JIRA 4.4#649-r158309.