<< Back to previous view

[CONTRIB-98] c.c.json/json-str handles maps with keys containing quotes incorrectly Created: 30/Sep/10  Updated: 26/Nov/10  Resolved: 26/Nov/10

Status: Resolved
Project: Clojure-Contrib
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect
Reporter: Anonymous Assignee: Stuart Sierra
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File clojure-contrib-json-98.patch    
Patch: Code and Test

 Description   

Consider:

> (println (json-str {"\"" 1})) 
{""":1} 
</code></pre>

...while I (and my parsers) would expect <pre><code>{"\"":1}
.

This happens in both contrib 1.2.0 and 1.3-alpha1.



 Comments   
Comment by Assembla Importer [ 28/Oct/10 3:05 PM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/98

Comment by Jan Rychter [ 29/Oct/10 2:37 AM ]

The enclosed patch escapes object keys. It passes all tests. I've added a test that fails without the fix and passes with it.

Comment by Jan Rychter [ 04/Nov/10 11:18 AM ]

I've been told that issues are marked as "resolved" only after the patch gets applied. I'm reopening the issue, then, hoping that someone will pick it up from here.

Comment by Stuart Sierra [ 18/Nov/10 5:11 PM ]

Patch does not apply, appears to be formatted for contrib pre-modularization.

Comment by Stuart Sierra [ 26/Nov/10 9:11 AM ]

Rewrote patch to work with modularized contrib; applied in d6f6ccfaeac03e35b1f9dbfa04424866cd9b2a41

Comment by Daniel Janus [ 26/Nov/10 4:17 PM ]

Is this going to be backported to 1.2 branch? It would be greatly appreciated.

Generated at Mon Oct 20 16:45:29 CDT 2014 using JIRA 4.4#649-r158309.