[CTYP-154] A few more issues discovered via linting Created: 10/Jun/14 Updated: 10/Jun/14 Resolved: 10/Jun/14
|Reporter:||Andy Fingerhut||Assignee:||Ambrose Bonnaire-Sergeant|
I can include a patch if you want, but given that you may want to make some but not all of these changes, I will just describe them for now.
src/main/clojure/clojure/core/typed.clj has two nearly identical occurrences of function reset-cache. One returns nil explicitly, the other does not. Best to have only one implementation.
src/main/clojure/clojure/core/typed/check.clj has an expression (assoc-in [:types kt] vt) that appears to be the wrong number of args for assoc-in. I am not sure what is intended there.
src/main/clojure/clojure/core/typed/errors.clj has two def's for int-error-kw. One would be better.
src/main/clojure/clojure/core/typed/subtype.clj has an expression (and (r/HSet? s)) that could be replaced with (r/HSet? s)
|Comment by Ambrose Bonnaire-Sergeant [ 10/Jun/14 10:58 PM ]|