iterable.patch
[DPRIMAP-1] Implement java.lang.Iterable Created: 04/Sep/12 Updated: 09/Sep/12 Resolved: 09/Sep/12 |
|
| Status: | Resolved |
| Project: | data.priority-map |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Defect | Priority: | Major |
| Reporter: | Alan Malloy | Assignee: | Sean Corfield |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
iterable.patch
|
| Patch: | Code |
| Description |
|
Clojure collections are expected to implement all relevant java collection interfaces, and things will quietly and subtly break if any are missed. In this case, the reducers library assumes all instances of java.util.Map implement java.lang.Iterable, and since this one doesn't it can't reduce over us, even inefficiently. |
| Comments |
| Comment by Sean Corfield [ 09/Sep/12 2:30 AM ] |
|
The patch from Alan did not apply but it was only a two line addition so I did that manually. Passes current tests but there are no new tests for Iterable (yet). |