[LOGIC-135] membero should be updated to use disequality constraints Created: 07/May/13 Updated: 28/Jul/13 Resolved: 07/May/13
|Reporter:||Austin Haas||Assignee:||David Nolen|
William Byrd considers the version of membero that appears in core.logic to be outdated and inferior to a version that uses disequality constraints. Full discussion here: http://youtu.be/MTAhbsWUUxM?t=1h20m00s
Patch to follow.
|Comment by Austin Haas [ 07/May/13 5:33 PM ]|
This patch improves membero by adding a disequality constraint. Fix for
Note that this patch removes two tests that depended on assumptions that have nothing to do with the correctness of membero.
|Comment by Austin Haas [ 07/May/13 5:41 PM ]|
Regarding the tests, the first broke because it assumed reified fresh lvars wouldn't include disequality constraints.
For the 2nd one, test-116-constraint-store-migrate, I have not looked into it thoroughly, but I got the impression that the test needs to be rewritten. I'd argue that it is more important to fix membero before fixing that test (but I don't know what else that test is testing).
|Comment by David Nolen [ 07/May/13 10:24 PM ]|