<< Back to previous view

[LOGIC-51] fd comparison relations behave strange when used with literals Created: 07/Sep/12  Updated: 26/Oct/12  Resolved: 26/Oct/12

Status: Resolved
Project: core.logic
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Tassilo Horn Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None
Environment:

java version "1.7.0_07"
OpenJDK Runtime Environment (IcedTea7 2.3.2) (Gentoo build 1.7.0_07-b30)
OpenJDK 64-Bit Server VM (build 23.2-b09, mixed mode)

org.clojure/clojure "1.5.0-alpha4"
org.clojure/core.logic "0.8-alpha3"


 Description   

The fd comparison relations always succeed when used with strings or a string and an integer:

user> (run* [q]
 (<=fd "foo" "bar"))
(_.0)
user> (run* [q]
 (<=fd "foo" 1))
(_.0)
user> (run* [q]
 (<=fd 1 "bar"))
(_.0)

IMHO, they should always fail if one argument is not a integer.

Furthermore, you get an exception when comparing integers and the larger integer is given first.

user> (run* [q]
 (<=fd 1 2))
(_.0)  ;; That's correct, but...
user> (run* [q]
 (<=fd 2 1))
IllegalArgumentException No implementation of method: :member? of protocol: #'clojure.core.logic/ISet found for class: nil  clojure.core/-cache-protocol-fn (core_deftype.clj:533)

I'd expect that comparisons of two integers should always work. You can circumvent this issue by unifying the numbers with some logic variables first, but is that really needed?

user> (run* [q]
 (fresh [a b]
  (== a 1)
  (== b 2)
  (<=fd a b)))
(_.0)
user> (run* [q]
 (fresh [a b]
  (== a 1)
  (== b 2)
  (<=fd b a)))
()

The first issue cannot be circumvented using this approach, though.

user> (run* [q]
 (fresh [a b]
  (== a "foo")
  (== b 2)
  (<=fd b a)))
(_.0)
user> (run* [q]
 (fresh [a b]
  (== a "foo")
  (== b 2)
  (<=fd a b)))
(_.0)
user> (run* [q]
 (fresh [a b]
  (== a "foo")
  (== b "bar")
  (<=fd a b)))
(_.0)
user> (run* [q]
 (fresh [a b]
  (== a "foo")
  (== b "bar")
  (<=fd b a)))
(_.0)


 Comments   
Comment by David Nolen [ 07/Sep/12 11:14 AM ]

Thanks for the report will look into it.

Comment by David Nolen [ 26/Oct/12 1:06 AM ]

I see no particular need to validate inputs. The other issues should be resolved in one of the latest betas.

Comment by Tassilo Horn [ 26/Oct/12 2:01 AM ]

> I see no particular need to validate inputs.

Well, the reported behavior ("every non-integer is both smaller and greater than anything") is likely to hide bugs in queries. But hey, even if you don't see a particular need, something you did fixed that problem anyhow.

This is with 0.8.0-beta1:

user> (run* [q] (<=fd 23 "1"))
IllegalArgumentException No implementation of method: :ub of protocol: #'clojure.core.logic/IInterval found for class: java.lang.String  clojure.core/-cache-protocol-fn (core_deftype.clj:562)
user> (run* [q] (<=fd "1" 23))
IllegalArgumentException No implementation of method: :lb of protocol: #'clojure.core.logic/IInterval found for class: java.lang.String  clojure.core/-cache-protocol-fn (core_deftype.clj:562)

IMO, both an exception and simply failing would be ok in those situations. Exception like now is probably even better.

> The other issues should be resolved in one of the latest betas.

Yes, it is. Thanks a lot, David! Feel free to close this issue.

Comment by David Nolen [ 26/Oct/12 7:04 AM ]

Thanks for the update!

Generated at Wed Jun 19 03:13:53 CDT 2013 using JIRA 4.4#649-r158309.