<< Back to previous view

[LOGIC-60] Simple unification and partial-map support for ClojureScript Created: 25/Oct/12  Updated: 28/Jul/13  Resolved: 26/Oct/12

Status: Closed
Project: core.logic
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Major
Reporter: Paul deGrandis Assignee: Paul deGrandis
Resolution: Completed Votes: 0
Labels: None

Attachments: File logic-60-simple-unification-partmap-2.diff     File logic-60-simple-unification-partmap-3.diff     File logic-60-simple-unification-partmap.diff    

 Description   

This ports over the simple unifier (and prep and binding-map) as well as the partial-map support into ClojureScript. Additionally some deprecated protocol use was patched up.



 Comments   
Comment by David Nolen [ 25/Oct/12 11:11 AM ]

This looks great but could we copy over the related tests for simple unification and partial map unification? You can run these with script/test. Thanks.

Comment by Paul deGrandis [ 25/Oct/12 12:39 PM ]

I promise to write tests from now on

I patched up one bug, noted the failing unification for partial-map (I will open a new ticket for it).

Also, prep is failing on some JS Object because of a with-meta call. See the tests for the cases where that happens. I couldn't figure it out, but I haven't hit this in my project code (I'm doing extremely simple unification and binding-map stuff).
I'll open up a new ticket for that as well.

===
edit: take version 3 - removed print statements I left in the test file

Comment by David Nolen [ 26/Oct/12 12:40 AM ]

fixed, http://github.com/clojure/core.logic/commit/e33668ff0bd76aded94b7911e498c62473e47a6f

Generated at Fri Aug 01 23:33:42 CDT 2014 using JIRA 4.4#649-r158309.