[LOGIC-60] Simple unification and partial-map support for ClojureScript Created: 25/Oct/12 Updated: 26/Oct/12 Resolved: 26/Oct/12
|Reporter:||Paul deGrandis||Assignee:||Paul deGrandis|
|Attachments:||logic-60-simple-unification-partmap-2.diff logic-60-simple-unification-partmap-3.diff logic-60-simple-unification-partmap.diff|
This ports over the simple unifier (and prep and binding-map) as well as the partial-map support into ClojureScript. Additionally some deprecated protocol use was patched up.
|Comment by David Nolen [ 25/Oct/12 11:11 AM ]|
This looks great but could we copy over the related tests for simple unification and partial map unification? You can run these with script/test. Thanks.
|Comment by Paul deGrandis [ 25/Oct/12 12:39 PM ]|
I promise to write tests from now on
I patched up one bug, noted the failing unification for partial-map (I will open a new ticket for it).
Also, prep is failing on some JS Object because of a with-meta call. See the tests for the cases where that happens. I couldn't figure it out, but I haven't hit this in my project code (I'm doing extremely simple unification and binding-map stuff).
|Comment by David Nolen [ 26/Oct/12 12:40 AM ]|