<< Back to previous view

[LOGIC-63] Prep's use of metadata needs to be extended to other objects in ClojureScript Created: 26/Oct/12  Updated: 28/Jul/13  Resolved: 26/Oct/12

Status: Closed
Project: core.logic
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Paul deGrandis Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None


 Description   

The simple unifier and binding-map work great in the simple cases, but fail with more complicated unification.
The root cause is prep's use of metadata banging up against JS Objects.

For the cases that fail, see the current failing tests:
https://github.com/clojure/core.logic/blob/master/src/test/cljs/cljs/core/logic/tests.cljs#L871



 Comments   
Comment by David Nolen [ 26/Oct/12 12:42 PM ]

I still don't understand. Is it failing because it's trying to add metadata to objects which don't support that? That doesn't really make sense given the unifications that are failing that you've highlighted.

Comment by Paul deGrandis [ 26/Oct/12 12:55 PM ]

That's correct - I couldn't determine what the Object was in the code. Whatever it is, it just needs the IWithMeta protocol extended to it.

I thought you might have more insight.

Comment by David Nolen [ 26/Oct/12 12:58 PM ]

Ok will look into it.

Comment by David Nolen [ 26/Oct/12 5:53 PM ]

fixed http://github.com/clojure/core.logic/commit/371c0355f51ee35c6e71616ec2923a8242d6e4b3

Generated at Tue Sep 30 11:15:34 CDT 2014 using JIRA 4.4#649-r158309.