<< Back to previous view

[LOGIC-80] add fne, anonymous version of defne Created: 18/Dec/12  Updated: 28/Jul/13  Resolved: 09/Jun/13

Status: Closed
Project: core.logic
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File logic-80-3.patch    

 Comments   
Comment by Stanislas Nanchen [ 01/May/13 10:24 AM ]

The macros 'fnm' (and fn[eau]) use the optional argument :tabled after the argument list. Is it ok?

Comment by David Nolen [ 05/May/13 7:39 PM ]

tabling passed as an option is OK with me.

Also could we get tests? Thanks much!

Comment by Stanislas Nanchen [ 06/May/13 3:48 AM ]

I've used the existing pm tests to test the fne macro. you find it in the logic-80-2.patch. Is it what you had in mind?

It is not clear how I can test for tabled anonymous functions as the :tabled metadata is of the defn[x] vars.
Possibilities would be:

  • add meta-data to the function produced by the macro 'tabled';
  • let the function produced by tabled implement some interface/protocol.

what do you think?

Comment by David Nolen [ 07/May/13 10:31 PM ]

This looks good. Two things:

  • squashed patch
  • tabled anonymous goal patch
Comment by Stanislas Nanchen [ 09/May/13 1:38 AM ]

we're almost there

i do not understand what you mean. you prefer a separate patch for tabled anonymous goal?

Comment by David Nolen [ 09/May/13 8:11 AM ]

Sorry typo, I meant a test for the tabled anonymous goal. Thanks!

Comment by Stanislas Nanchen [ 10/May/13 10:51 AM ]

thanks, i'll do it asap.

Comment by Stanislas Nanchen [ 14/May/13 9:50 AM ]

Squashed Patch with tests for the fn[e] macros, normal and tabled.

Comment by Stanislas Nanchen [ 14/May/13 9:51 AM ]

so i finally got some time to look at it again. the patch is squashed and contains a test for the tabled anonymous goals; it just tests whether the macro code actually works.

Comment by David Nolen [ 17/May/13 12:53 AM ]

Thanks will take a look!

Comment by David Nolen [ 09/Jun/13 11:33 AM ]

fixed, http://github.com/clojure/core.logic/commit/a64ed2f3447bca78bb6f53244db5d5379ecd55f1

Generated at Mon Sep 01 02:53:36 CDT 2014 using JIRA 4.4#649-r158309.