<< Back to previous view

[MATCH-60] Matching maps with :only broken in CLJS Created: 18/Jun/12  Updated: 01/Jul/12  Resolved: 01/Jul/12

Status: Resolved
Project: core.match
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Kevin Lynagh Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File cljs_keyset.patch     Text File cljs_keyset.patch    
Patch: Code

 Description   

The `.keySet` method call doesn't exist on JavaScript objects.
Master throws compile errors on me, so I've attached a patch against alpha9 that removes the Java method call in favor of the pure Clojure `(set (keys m))`

 Comments   
Comment by David Nolen [ 18/Jun/12 10:49 AM ]

It would preferable to check the *clojurescript* dynamic var and do different emission. Thanks!

Comment by Kevin Lynagh [ 30/Jun/12 11:34 AM ]

Updated patch against master that uses clojurescript var. Also available at https://github.com/lynaghk/core.match/tree/60-cljs-keyset

Comment by David Nolen [ 01/Jul/12 11:03 AM ]

fixed, http://github.com/clojure/core.match/commit/cdeea55f211f1dbe4768c8aec3149bfcb00438a2

Generated at Thu May 23 22:07:56 CDT 2013 using JIRA 4.4#649-r158309.