nrepl-35-eliminate-reflection-v1.txt
[NREPL-35] Eliminate several uses of reflection in tools.nrepl Created: 28/Oct/12 Updated: 31/Oct/12 Resolved: 31/Oct/12 |
|
| Status: | Closed |
| Project: | tools.nrepl |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 0.2.0 |
| Type: | Enhancement | Priority: | Minor |
| Reporter: | Andy Fingerhut | Assignee: | Chas Emerick |
| Resolution: | Completed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
nrepl-35-eliminate-reflection-v1.txt
|
| Description |
|
There are several uses of reflection in tools.nrepl that can be eliminated with suitable type hints. |
| Comments |
| Comment by Andy Fingerhut [ 28/Oct/12 10:12 PM ] |
|
nrepl-35-eliminate-reflection-v1.txt dated Oct 28 2012 adds type hints to eliminate some of the reflection warnings in tools.nrepl. There are still some left over that are not as obvious how to eliminate, if it is even possible. |
| Comment by Chas Emerick [ 31/Oct/12 4:44 AM ] |
|
Thanks for the patch, but it overhinted in some areas (I try to keep hints at an absolute minimum to maximize readability) and overconstrained in others (e.g. ThreadPoolExecutor vs. Executor). Fixed @ https://github.com/clojure/tools.nrepl/commit/ac95dc7da973f3d7edea75d0f6f9ce01ee18641d |