<< Back to previous view

[TRDR-10] Add end-line and end-column metadata to read objects Created: 25/Oct/13  Updated: 08/Nov/13  Resolved: 06/Nov/13

Status: Closed
Project: tools.reader
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: Alexander Redington Assignee: Alexander Redington
Resolution: Completed Votes: 0
Labels: None

Attachments: File TRDR-10-line-numbering.diff    
Patch: Code and Test

 Description   

Per TRDR-9, add end-line and end-column metadata information to every form read, when the underlying reader implements the IndexingReader protocol.



 Comments   
Comment by Alexander Redington [ 25/Oct/13 12:03 PM ]

Patch to include end-line and end-column numbers on all forms read, with tests.

Comment by Nicola Mometto [ 06/Nov/13 3:26 PM ]

Applied to master: https://github.com/clojure/tools.reader/commit/a7251e87c5530e04c3c7c4a983f30030f38730df

I'm sorry I didn't apply this earlier but JIRA didn't send me an email notifying me that you updated the patch even though I am watching the issue.

Comment by Alexander Redington [ 08/Nov/13 7:31 AM ]

I've only been working on this in Friday time, and even that has been sporadic, so nothing to worry about!

Working with you on this has been excellent, thanks for accepting the suggestions and patches!

Generated at Sat Oct 25 01:28:23 CDT 2014 using JIRA 4.4#649-r158309.