http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1029 Clojure <p>The form:</p> <p> (ns foo (:print "I AM A ROBOT"))</p> <p>will print "I AM A ROBOT"</p> <p>This is because the defmacro takes the name of the first element of the reference, looks it up in the clojure.core namespace and invokes it on the rest of the args.</p> <p>This is minor, but it does mean that an otherwise declarative form is not executing code.</p> all CLJ-1029

ns defmacro allows arbitrary execution of clojure.core fns

Defect Minor Open Unresolved Unassigned Craig Brozefsky Mon, 23 Jul 2012 21:00:38 -0500 Sun, 5 Aug 2012 10:00:07 -0500 Release 1.2 Release 1.3 Release 1.4 1 1 <p>One apparent problem with this patch is that you throw an exception for :refer. You should add that, and make sure there aren't any others missing. Also, #{x y z} is better than (set <span class="error">&#91;x y z&#93;</span>), and you should probably use pr-str rather than str, although I can't think of a case where it matters for the objects in question.</p> <p>A more minor detail of patch formatting &#8211; please attach your patch in git format. See the instructions under the section heading "Development" on this web page: <a href="http://dev.clojure.org/display/design/JIRA+workflow">http://dev.clojure.org/display/design/JIRA+workflow</a></p> <p>git format-patch version of the diff, with the edits suggested by other maintainers.</p> <p>Alan: please note that :refer was not mentioned in the docstring for ns, or used in any of the unit tests for clojure.</p> <p>Are you sure that it is an expected argument, or just an arrangement that happens to work under the current ns macro? The docstring for 'refer itself says to use :use in ns macros instead of calling refer.</p> <p>I added "refer" to the set of accepted references all the same.</p> Global Rank Patch Code