http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1066 Clojure <p>The Clojure 1.5.0-alpha4 jars that have been deployed to maven.org seem to have been compiled against JDK6 which causes<br/> an exception if one tries to use reducers/fold.</p> <p>&#8212; snip &#8212;<br/> Setup:</p> <p> user=&gt; (require '<span class="error">&#91;clojure.core.reducers :as r&#93;</span>)<br/> nil<br/> user=&gt; (def v (vec (range 10000)))<br/> #'user/v</p> <p>;; JDK7 + clojure 1.5.0-alpha4 from maven.org<br/> ;; → :dependencies [<span class="error">&#91;org.clojure/clojure &quot;1.5.0-alpha4&quot;&#93;</span>] in project.clj</p> <p> user=&gt; (r/fold + (r/map inc v))<br/> ClassNotFoundException jsr166y.ForkJoinTask java.net.URLClassLoader$1.run (URLClassLoader.java:366)</p> <p>;; JDK7 + clojure 1.5.0-alpha4 from maven.org<br/> ;; → :dependencies [<span class="error">&#91;org.clojure/clojure &quot;1.5.0-alpha4&quot;&#93;</span><br/> ;; <span class="error">&#91;org.codehaus.jsr166-mirror/jsr166y &quot;1.7.0&quot;&#93;</span>]</p> <p> user=&gt; (r/fold + (r/map inc v))<br/> 50005000</p> <p>;; JDK7 + clojure 1.5.0-alpha4 locally compiled (mvn install) against OpenJDK7<br/> ;; → :dependencies [<span class="error">&#91;org.clojure/clojure &quot;1.5.0-alpha4&quot;&#93;</span>] in project.clj</p> <p> user=&gt; (r/fold + (r/map inc v))<br/> 5000050000<br/> &#8212; snip &#8212;</p> <p>It would be wonderful if this issue could be fixed before the release of 1.5.0.</p> <p>Have a nice day</p> <p> Wolodja</p> $ java -version <br/> java version &quot;1.7.0_03&quot; <br/> OpenJDK Runtime Environment (IcedTea7 2.1.2) (7u3-2.1.2-2) <br/> OpenJDK 64-Bit Server VM (build 22.0-b10, mixed mode) <br/> $ lein version <br/> Leiningen 2.0.0-preview10 on Java 1.7.0_03 OpenJDK 64-Bit Server VM <br/> CLJ-1066

No dependency on jsr166y

Defect Major Closed Completed Stuart Halloway Wolodja Wentland patch Tue, 11 Sep 2012 10:21:51 -0500 Sat, 20 Oct 2012 09:53:42 -0500 Sat, 20 Oct 2012 09:53:42 -0500 Release 1.5 Release 1.5 4 5 <p>That's really a nasty problem. I wrote the code that makes it possible to compile clojure with either a JDK7 and native ForkJoin or an older JDK + jsr166y. Unfortunately, if you build clojure with a JDK7, reducers' fold requires a JDK7 at runtime, and if you build clojure with a JDK &lt;7 + jsr166y, fold also requires jsr166y at runtime.</p> <p>The essential problem is that clojure is AOT-compiled to class-files and those are put into the release jars. Ordinary clojure libraries are distributed as jar files containing clj files that are compiled when loaded. There, the implemented approach works just fine. For example, again your example with 1.5.0-alpha4:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>;; 1.5.0-master4 compiled with JDK6 + jsr166y running on a JDK7 user=&gt; (require '[clojure.core.reducers :as r]) nil user=&gt; (def v (vec (range 10000))) #'user/v user=&gt; (r/fold + (r/map inc v)) ClassNotFoundException jsr166y.ForkJoinTask java.net.URLClassLoader$1.run (URLClassLoader.java:366) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; Now load the reducers.clj source code again, so that it ;; picks the right ForkJoin-impl for the current platform (load-file "/home/horn/Repos/clj/clojure/src/clj/clojure/core/reducers.clj") nil user=&gt; (r/fold + (r/map inc v)) 50005000 </pre> </div></div> <p>So IMO, the best thing we can do is to omit AOT-compilation for reducers but to include only its clj file so that it'll be compiled automatically on the platform it eventually runs.</p> <p>This patch removes the clojure.core.reducers namespace from the namespaces to be AOT compiled. So now this namespace will be JIT-compiled when being required, and at that point either the JDK7 ForkJoin classes or the jsr166y classes need to be there.</p> <p>Rich: what is the right approach here?</p> Approval Ok Global Rank Patch Code