http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1076 Clojure <p>New pprint tests were committed recently, but they fail on Windows because the tests check for \n, while pprint seems to output \r\n. A log with the test failures is attached.</p> <p>The first failing commit is <a href="https://github.com/clojure/clojure/commit/4ca0f7ea17888ba7ed56d2fde0bc2d6397e8e1c0">https://github.com/clojure/clojure/commit/4ca0f7ea17888ba7ed56d2fde0bc2d6397e8e1c0</a></p> Windows 7 CLJ-1076

pprint tests fail on Windows, expecting \n

Defect Major Open Unresolved Unassigned Ivan Kozik Wed, 26 Sep 2012 02:34:19 -0500 Sat, 2 Mar 2013 14:51:46 -0600 Release 1.5 1 2 <p>Patch clj-1076-fix-tests-on-windows-patch-v1.txt dated Sep 29 2012 when applied to the particular commit that Ivan mentions causes the tests to pass when I run "ant" on a Windows 7 machine for me, and it continues to pass all tests on Mac OS X 10.6.8, too.</p> <p>I may be doing something wrong, but when I try to run "ant" to build and test on Windows 7 with latest Clojure master, with or without this patch, it fails right at the beginning of the tests because it can't find clojure.test.generative. I'm probably doing something wrong somewhere. Ivan, would you be able to test this patch on Windows with the latest Clojure master to see if all tests pass for you now?</p> <p>All tests pass on Windows 7 here with the patch.</p> <p>Ant can't find my test.generative either because it isn't in my "${maven.test.classpath}". I put it in CLASSPATH and modified my build.xml like this:<br/> <br/> &lt;java classname="clojure.main" failonerror="false" fork="true"&gt;<br/> &lt;classpath&gt;<br/> + &lt;pathelement path="${java.class.path}"/&gt;<br/> &lt;pathelement path="${maven.test.classpath}"/&gt;</p> <p>Just as a rough idea of how often people are hitting this issue, <a href="http://dev.clojure.org/jira/browse/CLJ-1123" title="UNIX/Windows line endings - clojure.pprint tests cause failure in Windows build"><del>CLJ-1123</del></a> was opened on Dec 9 2012 and then closed when the ticket creator realized it was a duplicate of this one.</p> <p>Hi there is this likely to get fixed soon?</p> <p>I'd like to help contribute some more patches to Clojure but it's tricky to do when I can't get the build to work <img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> <p>I do not know if or when this patch will be committed to Clojure.</p> <p>I can tell you that you can apply the patch to your own local copy of the Clojure source code, and then develop new Clojure patches based upon that version. The patch that fixes this problem only affects one test file, so it is unlikely to conflict with any changes you develop and submit.</p> <p>I can confirm this patch works fine for me on Windows with Maven/Eclipse</p> <p>Suggest this patch gets pushed through approval and applied ASAP? It's a pretty obvious fix that is breaking the build....</p> <p>This patch is sloppy &#8211; it makes unnecessary whitespace changes in several places.</p> <p>Would it be better to make the tests trailing whitespace agnostic? Otherwise this feels like poking and prodding until the build box is happy.</p> <p>Patch clj-1076-fix-tests-on-windows-patch-v2.txt dated Mar 2, 2013 fixes pprint tests on Windows in a different way: Removing all occurrences of carriage return (\r) characters in the output of pprint before comparing it to the expected string.</p> <p>I tried simply doing str/trim-newline to remove newlines and carriage returns at the end of the string, but that does not make the tests pass. They still fail due to carriage returns in the middle of the string.</p> <p>Presumptuously changing Approval from Incomplete back to None, since there is a new patch attached that should address the reason it was marked Incomplete.</p> Global Rank Patch Code and Test