http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1078 Clojure <p>Original patch added functions for PersistentQueue. queue, queue? and queue* match the list functions of the same naming conventions. Patches include updates to tests. </p> <p>In the updated patch, "queue" accepts a single collection argument as per Rich's suggestion, and does not provide a "queue*".</p> CLJ-1078

Added queue, queue* and queue? to clojure.core

Enhancement Trivial Open Unresolved Unassigned Timothy Baldridge data-structures queue Wed, 26 Sep 2012 23:38:59 -0500 Fri, 31 May 2013 10:05:34 -0500 Release 1.5 3 3 <p>Timothy, I tried applying both of these Sep 26, 2012 patches to latest Clojure master as of that date. I had to apply 0001-make-PersistentQueue-ctor-public.patch by hand since it failed to apply using git or patch. It built fine, but failed to pass several of the Clojure tests. Have you looked into those test failures to see if you can find the cause and fix them? I tested on Ubuntu 11.10 with Oracle JDK 1.6 and 1.7, and saw similar failures with both.</p> <p>Fixed the patch. Tests pass, created the patch, applied it to a different copy of the source and the tests still pass. So this new patch should be good to go.</p> <p>Timothy, I'm not sure how you are getting successful results when applying this patch. Can you try the steps below and see what happens for you? I get errors trying to apply the patch with latest Clojure master as of Oct 26, 2012. Also please use the steps on the JIRA workflow page to create a git format patch (<a href="http://dev.clojure.org/display/design/JIRA+workflow">http://dev.clojure.org/display/design/JIRA+workflow</a> under "Development" heading).</p> <p>% git clone git://github.com/clojure/clojure.git<br/> % cd clojure<br/> % patch -p1 &lt; queues.patch<br/> patching file src/clj/clojure/core.clj<br/> patching file src/jvm/clojure/lang/PersistentQueue.java<br/> Hunk #1 FAILED at 32.<br/> 1 out of 1 hunk FAILED &#8211; saving rejects to file src/jvm/clojure/lang/PersistentQueue.java.rej<br/> patching file test/clojure/test_clojure/data_structures.clj<br/> Hunk #1 succeeded at 123 with fuzz 2.<br/> Hunk #2 succeeded at 861 with fuzz 2.<br/> Hunk #3 FAILED at 872.<br/> 1 out of 3 hunks FAILED &#8211; saving rejects to file test/clojure/test_clojure/data_structures.clj.rej<br/> patching file test/clojure/test_clojure/java_interop.clj</p> <p>I was using git apply. I tried the method you show above, and now I'm seeing the same issues you show above. </p> <p>Just so you know, the preferred way to create and apply patches are the "git format-patch master --stdout &gt; patch.txt" to create a patch (after doing the branching commands described on the JIRA workflow page to create a branch for your changes), and the "git am --keep-cr -s &lt; patch.txt" to apply a patch. If a patch was created that way and applies cleanly with that command, then you are definitely good to go.</p> <p>The "patch -p1 &lt; patch.txt" command is just a secondary method sometimes used to try to apply patches that aren't in the format produced above, or have errors when applying using that method.</p> <p>Just so you know, the preferred way to create and apply patches are the "git format-patch master --stdout &gt; patch.txt" to create a patch (after doing the branching commands described on the JIRA workflow page to create a branch for your changes), and the "git am --keep-cr -s &lt; patch.txt" to apply a patch. If a patch was created that way and applies cleanly with that command, then you are definitely good to go.</p> <p>The "patch -p1 &lt; patch.txt" command is just a secondary method sometimes used to try to apply patches that aren't in the format produced above, or have errors when applying using that method.</p> <p>added patch</p> <p>That one applies cleanly and passes all tests. It should show up on the next list of prescreened patches. Thanks.</p> <p>we don't use the queue* convention elsewhere, e.g. vec and vector. I think queue should take a collection like vec and set. (queue <span class="error">&#91;1 2 3&#93;</span>) could be made to 'adopt' the collection as front.</p> <p>Patch queue.patch dated Oct 26 2012 no longer applies cleanly after recent <a href="http://dev.clojure.org/jira/browse/CLJ-1000" title="Performance drop in PersistentHashMap.valAt(...) in v.1.4 -- Util.hasheq(...) ?"><del>CLJ-1000</del></a> commits, but only because of one line of changed patch context. It still applies cleanly with "patch -p1 &lt; queue.patch". Not bothering to update the stale patch given Rich's comments suggesting more substantive changes.</p> <p>See also <a href="http://dev.clojure.org/jira/browse/CLJ-976" title="Implement reader literal and print support for PersistentQueue data structure">CLJ-976</a> (tagged literal support for PersistentQueue)</p> <p>Don't want to step on Timothy B's toes here, but it looks straightforward to adopt his patch to implement Rich's suggestion. I'd offer to give it a whack if nobody else wants the ticket now.</p> <p>Discussion initiated on clojure-dev: <a href="https://groups.google.com/forum/?fromgroups#!topic/clojure-dev/2BOqHm24Vc4">https://groups.google.com/forum/?fromgroups#!topic/clojure-dev/2BOqHm24Vc4</a></p> <p>This patch (if accepted) supersedes Timothy Baldridge's patch; it implements "queue" and "queue?" (but not "queue*"); "queue" accepts a collection rather than being a variadic function, as per Rich's suggestion.</p> Global Rank Patch Code and Test