http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1089 Clojure <p>According to the interface <a href="http://docs.oracle.com/javase/6/docs/api/java/io/InputStream.html#read(">http://docs.oracle.com/javase/6/docs/api/java/io/InputStream.html#read(</a>)<br/> InputStream.read() family of methods return -1 when the end of stream is reached.</p> <p>do-copy methods currently use a test: (pos? size) to determine whether eos is reached. This mostly works, but the specification is pretty clear in that InputStream implementations are allowed to return reads of zero bytes before returning more bytes.</p> <p>##EDIT changed title of ticket from "clojure.java.io/copy should test for -1 instead of 0 for end of stream"</p> CLJ-1089

clojure.java.io/copy interprets read count of 0 as eos

Defect Minor Closed Declined Unassigned Herwig Hochleitner Mon, 22 Oct 2012 15:35:15 -0500 Mon, 22 Oct 2012 16:57:16 -0500 Mon, 22 Oct 2012 16:57:16 -0500 0 0 <p>Attached patch changes do-copy methods to test for -1</p> <p>Herwig, can you elaborate on "the specification is pretty clear in that InputStream implementations are allowed to return reads of zero bytes before returning more bytes"?</p> <p>I ask because in the very InputStream documentation page you link to, it seems to explicitly say the opposite of what you claim: "If no byte is available because the stream is at the end of the file, the value -1 is returned; otherwise, at least one byte is read and stored into b."</p> <p>I reread the spec for InputStream.read and it clearly says </p> <p>"If no byte is available because the stream is at the end of the file, the value -1 is returned; otherwise, at least one byte is read and stored into b."</p> <p>The reason I originally thought of this as an issue was a misbehaving ServletInputStream from Jetty.</p> <p>I closed the issue as declined. Sorry for the noise!</p> Global Rank