http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1090 Clojure <p>If you make a function call indirectly by invoking a Var object (which derefs itself and invokes the result), the invocation parameters remain in the thread's local stack for the duration of the function call, even though they are needed only long enough to be passed into the deref'd function. As a result, passing a lazy seq into a function invoked in its Var form may run out of memory if the seq is forced inside that function. For example:</p> <p>(defn total <span class="error">&#91;xs&#93;</span> (reduce + 0 xs))<br/> (total (range 1000000000)) ; this works, though takes a while<br/> (#'total (range 1000000000)) ; this dies with out of memory error</p> <p>I can provide a patch if it would be useful. The fix should be trivial, something along the lines of wrapping each argN in clojure/lang/Var.java inside a Util.ret1(argN, argN = null) as is done in RestFn.java.</p> Probably all, but observed on Ubuntu 12.04, OpenJDK 6 CLJ-1090

Indirect function calls through Var instances fail to clear locals

Defect Minor Open Unresolved Unassigned Spencer Tipping performance Mon, 22 Oct 2012 18:43:19 -0500 Fri, 30 Nov 2012 14:26:45 -0600 Release 1.4 0 2 <p>Sorry, I typo'd the example. (defn total ...) should be (defn sum ...).</p> <p>fixed typeo in example</p> <p>Couldn't reproduce the exception, but the 2nd example did chew through about 4x the amount of memory. Vetting. </p> <p>adding a patch. Since most of Clojure ends up running this code in one way or another, I'd assert that tests are included as part of the normal Clojure test process. </p> <p>Patch simply calls Util.ret1(argx, argx=null) on all invoke calls. </p> <p>And as a note, both examples in the original report now have extremely similar memory usages. </p> <p>Sounds great, and the patch looks good too. Let me know if I need to do anything else.</p> Approval Vetted Global Rank Patch Code