http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-1107 Clojure <p>The implementation of clojure.core/get returns null if its argument is not a valid associative collection. However, calling 'get' on something which is neither nil nor an Associative collection is almost certainly a bug, and should be indicated by an exception.</p> <p>This behavior can obscure common programmer errors such as:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">(def a (atom {:a 1 :b 2}) (:foo a) ; forgot to deref a ;;=&gt; nil</pre> </div></div> <p><a href="http://dev.clojure.org/jira/browse/CLJ-932" title="contains? should throw exception on non-keyed collections"><del>CLJ-932</del></a> was accepted as a similar enhancement to 'clojure.core/contains?'</p> <p>Attached patch 0001 throws an IllegalArgumentException as the fall-through case of RT.getFrom.</p> CLJ-1107

'get' should throw exception on non-Associative argument

Enhancement Minor Open Unresolved Stuart Sierra Stuart Sierra Tue, 13 Nov 2012 13:20:33 -0600 Fri, 24 May 2013 12:31:42 -0500 1 0 <p>Patch clj-1107-throw-on-get-for-unsupported-types-patch-v2.txt dated May 24 2013 is identical to 0001-<a href="http://dev.clojure.org/jira/browse/CLJ-1107" title="&#39;get&#39; should throw exception on non-Associative argument">CLJ-1107</a>-Throw-exception-for-get-called-on-unsupport.patch dated Nov 13 2012, except it applies cleanly to latest master. A recent commit for <a href="http://dev.clojure.org/jira/browse/CLJ-1099" title="better error message when passing non-seq to seq"><del>CLJ-1099</del></a> changed many IllegalArgumentException occurrences to Throwable in the tests, which is the only thing changed in this updated patch.</p> Global Rank Patch Code and Test