http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-148 Clojure <p>I have a module that includes pprint and my own utils.</p> <p>When com.howard.lewisship.cascade.dom/write was changed from private to public I get the following error:</p> <p>java.lang.IllegalStateException: write already refers to: #'clojure.contrib.pprint/write in namespace: com.howardlewisship.cascade.test-views (test_views.clj:0)</p> <p>(ns com.howardlewisship.cascade.test-views ; line 15<br/> (:use<br/> (clojure.contrib test-is pprint duck-streams)<br/> (app1 views fragments)<br/> (com.howardlewisship.cascade config dom view-manager)<br/> com.howardlewisship.cascade.internal.utils))</p> <p>That line number is wrong but better yet, identifying the true conflict (com.howard.lewisship.cascade.dom/write) would be even more important.</p> CLJ-148

Poor reporting of symbol conflicts when using (ns)

Enhancement Open Unresolved Unassigned None Fri, 10 Jul 2009 00:08:00 -0500 Tue, 28 Jun 2011 18:42:50 -0500 Backlog 1 0 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/148">http://www.assembla.com/spaces/clojure/tickets/148</a></p> <p>scgilardi said: It's saying that the symbol com.howardlewisship.cascade.test-views/write already resolves to #���clojure.contrib.pprint/write, so you can't def a new write in com.howardlewisship.cascade.test-views.</p> <p>What do you propose for an alternate wording of the error message here?</p> <p>I think the issue is that only one side of the conflict is reported in the error, so if you get this kind of error in the middle of a large project it can be hard to figure out which namespace is conflicting. Take a toy example:</p> <p>user=&gt; (ns foo)<br/> foo=&gt; (def foobar 42)<br/> foo=&gt; (ns bar)<br/> bar=&gt; (def foobar 0)<br/> bar=&gt; (ns problem)<br/> problem=&gt; (refer 'foo)<br/> problem=&gt; (refer 'bar)<br/> java.lang.IllegalStateException: foobar already refers to: #'foo/foobar in namespace: problem (NO_SOURCE_FILE:0)</p> <p>In this case it would be best if the error said something like:</p> <p>"Conflict referring to #'bar/foobar in #&lt;Namespace problem&gt; because foobar already refers to: #'foo/foobar."</p> <p>This way the error message clearly identifies the location of the conflict, and the locations of the two conflicting vars.</p> <p>Hopefully this helps clarify. I think I see where to fix it in warnOrFailOnReplace on line 88 of src/jvm/clojure/lang/Namespace.java, and this reminds me I need to send in a CA so I can pitch in next time...</p> <p>It looks like the true conflict is in test-views, not in dom. A small example of the line number breakage showing the problem on master (1.3) would be very helpful.</p> Approval Not Approved Global Rank