http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-184 Clojure <p>Add an &amp;more version to the bit operations bit-and bit-or bit-xor bit-and-not (via reduce),<br/> Inline the n-ary version of the math ops, + - * /, inline the n-ary versions of bit-and bit-or bit-xor bit-and-not</p> CLJ-184

n-ary bit functions, also inlining of n-ary bit and math operations

Enhancement Major Closed Completed Alan Dipert Assembla Importer Wed, 26 Aug 2009 17:37:00 -0500 Fri, 1 Mar 2013 12:47:03 -0600 Sat, 14 May 2011 16:21:04 -0500 Release 1.3 0 0 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/184">http://www.assembla.com/spaces/clojure/tickets/184</a><br/> Attachments:<br/> inlinemath.patch - <a href="https://www.assembla.com/spaces/clojure/documents/dlFRFQKPyr3RaoeJe5aVNr/download/dlFRFQKPyr3RaoeJe5aVNr">https://www.assembla.com/spaces/clojure/documents/dlFRFQKPyr3RaoeJe5aVNr/download/dlFRFQKPyr3RaoeJe5aVNr</a></p> <p>Jonathan A Smith said: [<a href="file:dlFRFQKPyr3RaoeJe5aVNr">file:dlFRFQKPyr3RaoeJe5aVNr</a>]: inline math and bit-or patch file</p> <p>Jonathan A Smith said: original math defs stay, new ones get re-defined after proxy is available.</p> <p>mikehinchey said: Applies clean (though has extra whitespace and tabs). Existing tests still pass.</p> <p>Jonathan A Smith said: The defn functions are within a let, which means that they get tabbed in by Emacs ctrl+alt+Q. Is this the referred to 'extra whitespace and tabs'?</p> <p>I think that this line: <br/> &gt;0-arities (rule-set (fn <span class="error">&#91;x&#93;</span> (&gt; x 1)))</p> <p>might be a mistake, and perhaps should be:<br/> &gt;0-arities (rule-set (fn <span class="error">&#91;x&#93;</span> (&gt; x 0)))</p> <p>But I will have to look at it and rebuild it when I get home tonight. resulting tests would still pass as the only effected function would be the single arity subtraction operation.</p> <p>mikehinchey said: "git am" complained about whitespace at the ends of lines. When I tab on each line to re-indent, emacs replaced tabs with spaces and deleted space at the end. Also, you could combine the 2 let blocks into 1.</p> <p>richhickey said: This still needs work. I'd like to avoid the need for proxy. It would be easy to make Compiler.isInline() in the compiler presume :inline-arities is an IFn (so sets literals would still work, but so would predicate fns)</p> <p>richhickey said: I've made that change, so isInline now treats :inline-arities as a predicate IFn. This should allow for a simpler implementation</p> <p>Adding patch from Assembla</p> <p>inlining and n-ary bit functions and math ops</p> <ul class="alternate" type="square"> <li>n-ary versions and inlines of bit-and, bit-or, bit-xor, bit-and-not</li> <li>n-ary inlines for +, +', *, *', /, -, -'</li> </ul> <p>This patch doesn't optimize / such that the &amp; more version expands to equivalent of (/ x (reduce * y more)) rather than (reduce / (/ x y) more). The original patch had a divide-by-zero bug, and I think adding this should be another ticket.</p> <p>Created <a href="http://dev.clojure.org/jira/browse/CLJ-785" title="Optimize /"><del>CLJ-785</del></a> for optimizing n-ary /</p> <p>You'd have less copypasta using this:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>(defn ^:private binary-inline ([op] (fn ([x y] `(. clojure.lang.Numbers (~op ~x ~y))) ([x y &amp; more] (reduce1 (fn [a b] `(. clojure.lang.Numbers (~op ~a ~b))) `(. clojure.lang.Numbers (~op ~x ~y)) more)))) ([op unchecked-op] (if *unchecked-math* (binary-inline unchecked-op) (binary-inline op)))) (defn ^:private &gt;1? [n] (clojure.lang.Numbers/gt n 1)) </pre> </div></div> <p>Also, <tt>^:static</tt> doesn't do anything anymore.</p> <p>The above was from <a href="https://github.com/ataggart/clojure/commits/n-ary">the branch I made</a>, that I mentioned in <a href="http://groups.google.com/group/clojure-dev/msg/a9d7d36f3c4f96bb">the thread on ticket status</a>. It also included a fix for the inefficient divide. </p> <p>Thanks, I'll extract a patch for this from your branch.</p> <p>This patch incorporates Alex Taggart's work in the comments, but leaves out the change to <tt>/</tt>. It made a call to the nonexistent Numbers/unchecked_divide method and multiplies in the denominator, which is faster but has different overflow behavior than divide/reduce.</p> <p>One problem with the patch: while the bit-ops fns have n-ary support for their inlines, the fns themselves do not. They need to be updated to something like:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>(defn bit-and "Bitwise and" {:inline (nary-inline 'and) :inline-arities &gt;1? :added "1.0"} ([x y] (. clojure.lang.Numbers and x y)) ([x y &amp; more] (reduce1 bit-and (bit-and x y) more))) </pre> </div></div> <p>Attached 184-inlining-nary-math-3.diff. Same as previous patch, but adds n-ary version of bit fns in addition to inlines, which were missing as Alex Taggart pointed out. Thanks for catching that!</p> <p>Patch is in 1.3-alpha7</p> Approval Ok Global Rank