http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-286 Clojure <p>There seem to be several places in clojure/contrib where <b>out</b> is being used as a java.io.PrintWriter, despite being documented as of type java.io.Writer<br/> Examples are: </p> <ul class="alternate" type="square"> <li>The reflection warnings from the compiler</li> <li>Exception printouts from contrib.sql</li> </ul> <p>This causes very confusing errors, when <b>out</b> isn't actually a PrintWriter, for example in a swank repl where it is a StringWriter.</p> <p>I've created a patch for the reflection warnings, but can't submit it here because of political issues.</p> CLJ-286

*out* being used as java.io.PrintWriter

Defect Closed Completed Unassigned None Mon, 29 Mar 2010 16:37:00 -0500 Thu, 14 Oct 2010 14:27:00 -0500 Thu, 14 Oct 2010 14:27:00 -0500 Release 1.3 0 0 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/286">http://www.assembla.com/spaces/clojure/tickets/286</a><br/> Attachments:<br/> 0001-fix-clojure.main-to-not-assume-that-err-is-a-PrintWr.patch - <a href="https://www.assembla.com/spaces/clojure/documents/cEQbXEuiar367beJe5d-aX/download/cEQbXEuiar367beJe5d-aX">https://www.assembla.com/spaces/clojure/documents/cEQbXEuiar367beJe5d-aX/download/cEQbXEuiar367beJe5d-aX</a><br/> 0286-out-writer-and-better-pst.patch - <a href="https://www.assembla.com/spaces/clojure/documents/b4nAPA16Gr34ZzeJe5cbLA/download/b4nAPA16Gr34ZzeJe5cbLA">https://www.assembla.com/spaces/clojure/documents/b4nAPA16Gr34ZzeJe5cbLA/download/b4nAPA16Gr34ZzeJe5cbLA</a></p> <p>rnewman said: See</p> <p><a href="https://www.assembla.com/spaces/clojure-contrib/tickets/55-clojure-contrib-sql-expects-*err*-to-be-a-printwriter">https://www.assembla.com/spaces/clojure-contrib/tickets/55-clojure-contrib-sql-expects-*err*-to-be-a-printwriter</a></p> <p>and the associated discussion on the group.</p> <p>Clojure's <b>out</b> is actually intended to be a PrintWriter; it's a documentation issue.</p> <p>djpowell said: [<a href="file:cEQbXEuiar367beJe5d-aX">file:cEQbXEuiar367beJe5d-aX</a>]: Fix for related printwriter issue</p> <p>djpowell said: There was also some discussion that <b>out</b> should not be assumed to be a PrintWriter:</p> <p><a href="http://groups.google.co.uk/group/clojure-dev/browse_thread/thread/99aa2b3263a0b374?hl=en">http://groups.google.co.uk/group/clojure-dev/browse_thread/thread/99aa2b3263a0b374?hl=en</a></p> <p>I've attached a patch for the related issue of <b>err</b> being assumed to be a PrintWriter. I think this is the only place in clojure itself, although there are other places in contrib.</p> <p>stu said: [<a href="file:b4nAPA16Gr34ZzeJe5cbLA">file:b4nAPA16Gr34ZzeJe5cbLA</a>]</p> <p>stu said: Second patch subsumes first, plus two additions</p> <ul> <li>applies the same fix to the new pst function</li> <li>improves usability of pst. pst's defaulting for the single-arity case was the opposite of what I expected, and the resulting error message is spectacularly confusing. Since the defaulting could trivially be extended to meet my expectations (pass an exception) without breaking the existing (pass a depth), I made it support both.</li> </ul> <p>I don't like binding <b>out</b> to <b>err</b>, but the entire print plumbing drives you in this direction.</p> <p>stu said: Updating tickets (#182, #286)</p> Approval Ok Global Rank