http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-342 Clojure <p>As discussed on clojure-dev at &lt;<a href="http://groups.google.com/group/clojure-dev/browse_thread/thread/97137884bb33f8ee">http://groups.google.com/group/clojure-dev/browse_thread/thread/97137884bb33f8ee</a>&gt;, I would like to enhance (vector-of) so that it can create a populated vector. There are two ways to do this:</p> <p>1. Like vector, take an arbitrary number of arguments used to populate the array.<br/> 2. Like vec, take a collection and use it to populate the array.</p> CLJ-342

Enhance (vector-of) to populate vector

Enhancement Minor Closed Completed Daniel Solano Gómez Assembla Importer Wed, 5 May 2010 21:25:00 -0500 Sun, 20 Mar 2011 08:46:37 -0500 Sun, 20 Mar 2011 08:46:36 -0500 Approved Backlog 1 0 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/342">http://www.assembla.com/spaces/clojure/tickets/342</a><br/> Attachments:<br/> 342-enhance-vector-of.patch - <a href="https://www.assembla.com/spaces/clojure/documents/ciVMWWwl8r35ypeJe5cbLr/download/ciVMWWwl8r35ypeJe5cbLr">https://www.assembla.com/spaces/clojure/documents/ciVMWWwl8r35ypeJe5cbLr/download/ciVMWWwl8r35ypeJe5cbLr</a></p> <p>dsg said: [<a href="file:ciVMWWwl8r35ypeJe5cbLr">file:ciVMWWwl8r35ypeJe5cbLr</a>]</p> <p>dsg said: I have attached a patch that implements the proposed enhancement. I am fairly certain it is not the absolutely highest performance implementation.</p> <p>I have not taken a lot of time to thoroughly study the code, but I think there is probably a way to create the initial array and pass it as an argument to the constructor, which would avoid a lot of the cons calls.</p> <p>Nonetheless, I think it is important enough to provide convenience of the interface. The implementation can always be changed later.</p> <p>richhickey said: You can't have it both ways. vector-of should be like vector, I think.</p> <p>I have updated my patch to reflect Rich's recommendation. vector-of now behaves similarly to vector.</p> <p>Includes tests.</p> <p>For the 1,2,3 cases it's better to create an array of that size and .aset am into it, please. &amp; rest case could bootstrap with 3-arg call as well.</p> <p>Thanks.</p> <p>Updated patch to reflect Rich's suggestions.</p> Approval Ok Global Rank Waiting On stu