http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-428 Clojure <p>See dev thread at <a href="http://groups.google.com/group/clojure-dev/browse_thread/thread/fdb000cae4f66a95">http://groups.google.com/group/clojure-dev/browse_thread/thread/fdb000cae4f66a95</a>.</p> <p>Note: subseq currently returns () instead of nil in some situations. If the rest of this idea dies we might still want to fix that.</p> CLJ-428

subseq, rsubseq enhancements to support priority maps?

Enhancement Minor Open Unresolved Unassigned Assembla Importer Fri, 20 Aug 2010 08:01:00 -0500 Wed, 1 May 2013 02:44:36 -0500 Approved Backlog Approved Backlog 2 3 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/428">http://www.assembla.com/spaces/clojure/tickets/428</a></p> <p>Patch clj-428-change-Sorted-seqFrom-to-take-inclusive-patch-v1.txt dated Apr 28 2013 was written by Mark Engelberg in July 2010, and was attached to a message he sent to the dev thread linked in the description. The approach he takes is described by him in that thread, copied here:</p> <p>----------------------------------------<br/> Meanwhile, to initiate discussion on how to modify subseq, I've attached a proposed patch. This patch works by modifying the seqFrom method of the Sorted interface to take an additional "inclusive" parameter (i.e., &lt;= and &gt;= are inclusive, &lt; and &gt; are not).</p> <p>In this patch, I do not address one issue I raised before, which is whether subseq implies by its name that it should return a seq rather than a sequence (in other words nil rather than ()). If seq behavior is desired, it would be necessary to wrap a call to seq around the calls to take-while. But for now, I'm just making the behavior match the current behavior.</p> <p>Although I think this is the cleanest way to address the extensibility issue with subseq, the change to seqFrom will break anyone who currently is overriding that method. I didn't see any such classes in clojure.contrib, so I don't think it's an issue, but if this is a concern, my other idea is to fix the problem entirely within subseq by changing the calls to next into calls to drop-while. I have coded this to confirm that it works, and can provide that alternative patch if desired.<br/> ----------------------------------------</p> <p>I can also supply a patch that uses drop-while in clojure.core/subseq and rsubseq if such an approach is preferred to the one in this patch.</p> <p>clj-428-change-Sorted-seqFrom-to-take-inclusive-patch-v2.txt dated Apr 28 2013 is same as clj-428-change-Sorted-seqFrom-to-take-inclusive-patch-v1.txt (soon to be deleted), except it adds tests for subseq and rsubseq, and corrects a bug in that patch. The approach is the same as described above for that patch.</p> <p>Patch clj-428-change-Sorted-seqFrom-to-take-inclusive-patch-v3.txt dated May 1 2013 is the same as clj-428-change-Sorted-seqFrom-to-take-inclusive-patch-v1.txt, still with the bug fix mentioned for -v2, but with some unnecessary changes removed from the patch. The comments for -v1.txt on the approach still apply.</p> Global Rank Patch Code