http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-433 Clojure <p>munge is overeager in converting $ to <em>DOLLARSIGN</em>, since $ is a valid<br/> character in Java identifiers:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">user&gt; (filter #(<span class="code-object">Character</span>/isJavaIdentifierPart %) (keys clojure.lang.<span class="code-object">Compiler</span>/CHAR_MAP)) (\$)</pre> </div></div> <p>On a related point, ' (single quote) is not admissible in Java<br/> identifiers, but it is not munged on master:</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">user=&gt; (<span class="code-object">Character</span>/isJavaIdentifierPart \') <span class="code-keyword">false</span> user=&gt; (munge <span class="code-quote">"'"</span>) <span class="code-quote">"'"</span></pre> </div></div> <p>This leads to e.g.</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">user=&gt; *' #&lt;core$_STAR_' clojure.core$_STAR_'@5adf48c4&gt;</pre> </div></div> <p>(note the ' after <em>STAR</em>). </p> <p>Originally reported <a href="http://groups.google.com/group/clojure-dev/browse_thread/thread/9caab13eafa10f80">on the Dev list</a>.</p> <p>See also <a href="http://groups.google.com/group/clojure/browse_thread/thread/7753adc5453d7410">this thread</a> on the (regular) Clojure ggroup.</p> <p>The attached patch applies cleanly against current master.</p> CLJ-433

munge should not munge $ (which isJavaIdentifierPart), should munge ' (which is not)

Defect Major Closed Completed Unassigned Assembla Importer Thu, 9 Sep 2010 06:03:00 -0500 Fri, 1 Mar 2013 12:46:59 -0600 Wed, 5 Jan 2011 06:49:34 -0600 Release 1.3 0 1 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/433">http://www.assembla.com/spaces/clojure/tickets/433</a><br/> Attachments:<br/> 0001-munge-no-longer-changes-to-<em>DOLLARSIGN</em>.patch - <a href="https://www.assembla.com/spaces/clojure/documents/dp5tziVaer34yIeJe5cbLr/download/dp5tziVaer34yIeJe5cbLr">https://www.assembla.com/spaces/clojure/documents/dp5tziVaer34yIeJe5cbLr/download/dp5tziVaer34yIeJe5cbLr</a></p> <p>Patch is clean, the real issue here is doing the right thing. Two concerns:</p> <ul> <li>was the original choice to munge $ motivated, and if so do we need a more subtle patch that preserves that original intent?</li> <li>presumably this is (yet another) binary-compatibility-breaking change. 1.3 already has major change, so now is a good a time as any...</li> </ul> <p>This issue mentions two problems but patch fixes only one. Should add the single-quote handling</p> <p>Right, I forgot about that in the patch somehow. Also, I just noticed that " is also not JavaIdentifierPart and yet is not currently munged. The newly attached patch fixes all three issues.</p> Approval Ok Global Rank