http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-69 Clojure <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">Reported by wolfe.a.jason, Feb 04, 2009 Describe the feature/change. Add <span class="code-quote">"keyset"</span> to Clojure; make .keySet <span class="code-keyword">for</span> APersistentMap <span class="code-keyword">return</span> an IPersistentSet Was <span class="code-keyword">this</span> discussed on the group? If so, please provide a link to the discussion: http:<span class="code-comment">//groups.google.com/group/clojure/browse_thread/thread/66e708e477ae992f/ff3d8d588068b60e?hl=en#ff3d8d588068b60e </span> ----------------------------------------------------- A patch is attached. Some notes: I chose to add a <span class="code-quote">"keyset"</span> function, rather than change the existing <span class="code-quote">"keys"</span>, so as to avoid breaking anything. The corresponding RT.keyset function just calls .keySet on the argument. I would have liked to have <span class="code-quote">"keyset"</span> <span class="code-keyword">return</span> an IPersistentSet even when passed a (non-Clojure) java.util.Map, but <span class="code-keyword">this</span> seems impossible to <span class="code-keyword">do</span> in sublinear time because of essentially the same limitation mentioned in the above thread (the Map <span class="code-keyword">interface</span> does not support getKey() or entryAt()) -- assuming, again, that <span class="code-quote">"get"</span> is supposed to <span class="code-keyword">return</span> the actual (identical?) key in a set, and not just an .equal key. I then changed the implementation of .keySet <span class="code-keyword">for</span> APersistentMap to essentially copy APersistentSet. A more concise alternative would have been to extend APersistentSet and override the .get method, but that made me a bit nervous (since <span class="code-keyword">if</span> APeristentSet changed <span class="code-keyword">this</span> could <span class="code-keyword">break</span>). Anyway, <span class="code-keyword">this</span> is my first patch <span class="code-keyword">for</span> the Java side of Clojure, and I'm not yet solid on the conventions and aesthetics, so comments/questions/criticisms/requests <span class="code-keyword">for</span> revisions are very welcome.</pre> </div></div> CLJ-69

GC Issue 66: Add "keyset" to Clojure; make .keySet for APersistentMap return IPersistentSet

Enhancement Minor In Progress Unresolved Unassigned Assembla Importer Wed, 17 Jun 2009 00:55:00 -0500 Fri, 10 Dec 2010 08:48:40 -0600 Approved Backlog Approved Backlog 0 0 <p>Converted from <a href="http://www.assembla.com/spaces/clojure/tickets/69">http://www.assembla.com/spaces/clojure/tickets/69</a><br/> Attachments:<br/> keyset.patch - <a href="https://www.assembla.com/spaces/clojure/documents/dKgE6mw3Gr3O2PeJe5afGb/download/dKgE6mw3Gr3O2PeJe5afGb">https://www.assembla.com/spaces/clojure/documents/dKgE6mw3Gr3O2PeJe5afGb/download/dKgE6mw3Gr3O2PeJe5afGb</a></p> <p>oranenj said: [<a href="file:dKgE6mw3Gr3O2PeJe5afGb">file:dKgE6mw3Gr3O2PeJe5afGb</a>]</p> <p>richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)</p> <p>patch not in correct format</p> Approval Incomplete Global Rank