http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-692 Clojure <p>Very minor, but noticed while browsing that "some" is defined as:</p> <p>(defn some<br/> ...<br/> <span class="error">&#91;pred coll&#93;</span><br/> (when (seq coll)<br/> (or (pred (first coll)) (recur pred (next coll)))))</p> <p>The "(seq coll)" call will potentially generate an unused seq each time.</p> Mac OS X Java 6 CLJ-692

Should "some" be using "seq?" rather than "seq" ?

Defect Minor Closed Declined Unassigned Matthew Phillips Thu, 16 Dec 2010 03:16:22 -0600 Fri, 8 Jul 2011 03:28:42 -0500 Mon, 27 Dec 2010 07:57:17 -0600 Release 1.2 0 1 <p>The `seq` function is the idiomatic way to ask the question "does this collection have something in it?" and is the correct approach in the case of `some`. If we were to use `seq?` then we would be asking an entirely different question: "does this collection implement the ISeq interface". In the case of using `seq?`, `some` would no longer work against the seq abstraction. It's tempting to look at the name `seq` and `seq?` and assume that they mean similar things. The type-based predicates are tricky. <img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> <p>Thanks for the informative comment Michael. I was just watching Rich's talk on seq's, and remembered making this noob bug report: sorry! <img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p> Global Rank