Clojure JIRA

Clojure JIRA http://dev.clojure.org/jira This file is an XML representation of an issue en-us

4.4

649

25-07-2011

[CLJ-713] Upgrade ASM to a more current version http://dev.clojure.org/jira/browse/CLJ-713 Clojure <ul> <li>Move to the latest ASM (currently 3.3.1)</li> <li>No longer subset-ed</li> <li>Still re-rooted it under clojure.asm</li> </ul> CLJ-713

Upgrade ASM to a more current version

Enhancement Minor Open Unresolved Unassigned Aaron Bedra Tue, 11 Jan 2011 22:47:00 -0600 Mon, 11 Mar 2013 15:43:51 -0500 Approved Backlog 0 2 <p>Attached is a patch that externalizes and moves the ASM lib to the latest version (4.1), which has support for invokeDynamic if a brave soul wants to emit that instruction. Heed fogus's caveats <span class="error">[3]</span>.</p> <p>ASM in this patch is not re-rooted, but an external Maven dependency. It does have the disadvantage of possibly conflicting with other dependents of ASM, but this is the same approach is used by other JVM langs.</p> <p>Can classloaders mitigate that problem?</p> <p><span class="error">[1]</span> Recent post on clojure-dev, oblivious of <span class="error">[2]</span> <a href="https://groups.google.com/d/msg/clojure-dev/iX-ZFPk_zyE/Es3mDOdG3bYJ">https://groups.google.com/d/msg/clojure-dev/iX-ZFPk_zyE/Es3mDOdG3bYJ</a><br/> <span class="error">[2]</span> <a href="https://groups.google.com/d/msg/clojure-dev/ahJXBT1vG68/_fEEM6Lc7LcJ">https://groups.google.com/d/msg/clojure-dev/ahJXBT1vG68/_fEEM6Lc7LcJ</a><br/> <span class="error">[3]</span> <a href="http://blog.fogus.me/2011/10/14/why-clojure-doesnt-need-invokedynamic-but-it-might-be-nice/">http://blog.fogus.me/2011/10/14/why-clojure-doesnt-need-invokedynamic-but-it-might-be-nice/</a></p> <p>Ran some of Andy Fingerhut's expression microbenchmarks on -master with the patch. There is no difference between performance compared to 1.5.1.</p> <p>Ghadi, out of curiosity, if you do AOT compilation of some Clojure class files, does it produce byte-for-byte identical .class files after your changes vs. before your changes? If so, that would be pretty high assurance of no problems. If not, it would be good to understand what changed.</p> Global Rank Patch Code