http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-734 Clojure <p>It appears like the clojure compiler doesn't get the starting scope of let bindings right from the java debug interface perspective.</p> <p>The compiler sets the starting scope of a local to the let/loop body, rather than to immediately after the local is bound. So when you are stepping through a let statement in a debugger, you can't eval the already defined bindings until you get to the let body. </p> <p>Because it is a compiler problem, you see the symptoms with any jdi based debugger, (I've confirmed this on both jdb and cdt.)</p> <p>The fix is pretty straightforward. Just gen.mark() a label after each binding is emitted and use that in the gen.visitLocalVariable() call instead of the loopLabel. I've attached a patch for clojure 1.2 branch. (If there is interest I'll create one for clojure master.)</p> CLJ-734

starting scope of let bindings seems incorrect from jdi perspective

Defect Minor Closed Completed Unassigned George Jahad Sun, 30 Jan 2011 16:45:05 -0600 Fri, 11 Mar 2011 10:21:22 -0600 Fri, 11 Mar 2011 10:21:22 -0600 Release 1.2 Release 1.3 0 0 <p>here is the diff against the current clojure master branch.</p> <p>re-added patch in proper format</p> <p>To test: start clojure with a jdi port, (like 8050 below)<br/> java -agentlib:jdwp=transport=dt_socket,address=8050,server=y,suspend=n -cp /Users/georgejahad/incoming/clojure-1.3.0-alpha4/clojure.jar clojure.main</p> <p>Then start jdb and attach to that port like so:<br/> jdb -attach 8050</p> <p>Set a breakpoint on pmap from jdb:<br/> stop in clojure.core$pmap.invoke</p> <p>Invoke pmap from the clojure repl:</p> <p>(pmap inc (range 6))</p> <p>From jdb, step over the first line of pmap, (that binds the local n):<br/> next</p> <p>From jdb, try to print the just bound local:<br/> print n</p> <p>Without the patch, you'll see:<br/> com.sun.tools.example.debug.expr.ParseException: Name unknown: n<br/> n = null</p> <p>With it, you should see n equal to the correct value:<br/> n = 4</p> <p>Rich: does this need to be rewritten so that BindingInit is a value, or is the mutation of startScope ok?</p> <p>Patch works against master.</p> <p>Yes, it is weird to mutate bindinginit with emit-related info. Better to keep a map of bindinginit-&gt;label inside doEmit, please.</p> <p>fixed to use HashMap of labels</p> <p>Feb 26 patch is good</p> Approval Ok Global Rank Patch New