http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-784 Clojure <p>Currently, the <tt>min</tt> and <tt>max</tt> functions are quite slow, since they don't take advantage of new primitive math.</p> <p>Implement them in the same manner in which other primitive math functions are implemented for efficiency.</p> CLJ-784

Update min/max functions to take advantage of primitive math

Enhancement Major Closed Completed Luke VanderHart Luke VanderHart Fri, 29 Apr 2011 10:20:41 -0500 Fri, 1 Mar 2013 12:47:08 -0600 Thu, 26 May 2011 20:17:29 -0500 Release 1.3 Release 1.3 0 0 <p>This patch creates inline versions of min and max, combined with overloaded implementations in c.l.Numbers. It is over an order of magnitude faster using a test like this one (from 19 seconds to 1.2 seconds on my machine):</p> <div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent"> <pre class="code-java">(time (loop [a 0 b 10 c 5] (<span class="code-keyword">if</span> (&lt; a 1000000000) (recur (inc a) (min b c) (max c b)))))</pre> </div></div> <p>There are two patches. One is contagious, but returns primitives for (long, double) input. The other is not contagious and returns primitives only for (long,long) and (double,double) args, but is still substantially faster than the original version.</p> <p>The May 6 "take 3" patch eliminates a few contagions that were hiding in the earlier patch, and is hopefully good to go.</p> Approval Ok Global Rank Patch Code