http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-826 Clojure <p>From clojure.contrib.string 1.2, I have found myself using drop, take,<br/> and butlast. (These are more than just wrappers for String/substring,<br/> because they behave nicely when indices exceed the string length.) I<br/> like these methods in part because they match the behavior of<br/> corresponding sequence methods, but have better performance. This<br/> makes optimizing (when needed) easier. </p> CLJ-826

Include drop, take, butlast from clojure.contrib.string (1.2) in clojure.string 1.3

Enhancement Minor Closed Declined Unassigned Arthur Edelstein Mon, 8 Aug 2011 12:58:18 -0500 Fri, 2 Dec 2011 09:14:37 -0600 Fri, 2 Dec 2011 09:14:37 -0600 Backlog Backlog 3 2 <p>Attached patch for adding the methods.</p> <p>I intentionally left out the {:added "_"} from the vars since I have no idea when this will be added.</p> <p>This (as expected) causes this test to fail:<br/> <span class="error">&#91;java&#93;</span> FAIL in (public-vars-with-docstrings-have-added) (metadata.clj:42)<br/> <span class="error">&#91;java&#93;</span> expected: (= [] (remove (comp :added meta) public-vars-with-docstrings))<br/> <span class="error">&#91;java&#93;</span> actual: (not (= [] (#'clojure.string/butlast #'clojure.string/drop #'clojure.string/take)))</p> <p>Which is easily remedied. If desired, let me know what version this will be added to and I'll submit a new patch with the :added metadata included.</p> <p>I have attached a patch with "1.4" as the added version now that 1.3 has been released.</p> <p>The algorithms, docs, and tests look good. I think the functions would be better if they used clojure.core/subs like the rest of clojure.string does, instead of .substring. This is more idiomatic Clojure and allows you to avoid hinting the String arg.</p> <p>When a new patch is uploaded, please remember to set the Patch field of this ticket to "Code and Test" and the Approval field to "Test". Hopefully this will lead to faster screening.</p> <p>Attached a patch that uses subs instead of .substring (clj-826-add-take-drop-butlast-v3.diff).</p> <p>These fns were left out intentionally. Feel free to propose a contrib home for them, though.</p> Approval Test Global Rank Patch Code and Test Waiting On thnetos