http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-837 Clojure <p>The minimal test to trigger the verification error is :</p> <p>(deftype t <span class="error">&#91;__&#93;</span>) <br/> or<br/> (defrecord r <span class="error">&#91;__&#93;</span>)</p> <p>It works fine in clojure 1.2, 1.2.1</p> <p>Works fine with one underscore.</p> <p>Output from REPL:</p> <p>user=&gt; (defrecord r <span class="error">&#91;__&#93;</span>)<br/> CompilerException java.lang.VerifyError: (class: user/r, method: create signature: (Lclojure/lang/IPersistentMap;)Luser/r<img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/wink.gif" height="20" width="20" align="absmiddle" alt="" border="0"/> Expecting to find object/array on stack, compiling:(NO_SOURCE_PATH:2) </p> <p>Stack trace from slime session:</p> <p>(class: clojure/data/priority_map/r, method: create signature: (Lclojure/lang/IPersistentMap;)Lclojure/data/priority_map/r<img class="emoticon" src="http://dev.clojure.org/jira/images/icons/emoticons/wink.gif" height="20" width="20" align="absmiddle" alt="" border="0"/> Expecting to find object/array on stack<br/> <span class="error">&#91;Thrown class java.lang.VerifyError&#93;</span></p> <p>Restarts:<br/> 0: <span class="error">&#91;QUIT&#93;</span> Quit to the SLIME top level</p> <p>Backtrace:<br/> 0: java.lang.Class.forName0(Native Method)<br/> 1: java.lang.Class.forName(Class.java:247)<br/> 2: clojure.lang.RT.classForName(RT.java:2013)<br/> 3: clojure.lang.Compiler$HostExpr.maybeClass(Compiler.java:929)<br/> 4: clojure.lang.Compiler$HostExpr.access$400(Compiler.java:710)<br/> 5: clojure.lang.Compiler$NewExpr$Parser.parse(Compiler.java:2391)<br/> 6: clojure.lang.Compiler.analyzeSeq(Compiler.java:6368)<br/> 7: clojure.lang.Compiler.analyze(Compiler.java:6175)<br/> 8: clojure.lang.Compiler.analyze(Compiler.java:6136)<br/> 9: clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:5531)<br/> 10: clojure.lang.Compiler$FnMethod.parse(Compiler.java:4967)<br/> <span class="error">&#91;No Locals&#93;</span><br/> 11: clojure.lang.Compiler$FnExpr.parse(Compiler.java:3588)<br/> 12: clojure.lang.Compiler.analyzeSeq(Compiler.java:6366)<br/> 13: clojure.lang.Compiler.analyze(Compiler.java:6175)<br/> 14: clojure.lang.Compiler.analyzeSeq(Compiler.java:6356)<br/> 15: clojure.lang.Compiler.analyze(Compiler.java:6175)<br/> 16: clojure.lang.Compiler.access$100(Compiler.java:37)<br/> 17: clojure.lang.Compiler$DefExpr$Parser.parse(Compiler.java:492)<br/> 18: clojure.lang.Compiler.analyzeSeq(Compiler.java:6368)<br/> 19: clojure.lang.Compiler.analyze(Compiler.java:6175)<br/> 20: clojure.lang.Compiler.analyzeSeq(Compiler.java:6356)<br/> 21: clojure.lang.Compiler.analyze(Compiler.java:6175)<br/> 22: clojure.lang.Compiler.analyze(Compiler.java:6136)<br/> 23: clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:5531)<br/> 24: clojure.lang.Compiler$LetExpr$Parser.parse(Compiler.java:5832)<br/> 25: clojure.lang.Compiler.analyzeSeq(Compiler.java:6368)<br/> 26: clojure.lang.Compiler.analyze(Compiler.java:6175)<br/> 27: clojure.lang.Compiler.analyze(Compiler.java:6136)<br/> 28: clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:5531)<br/> 29: clojure.lang.Compiler$FnMethod.parse(Compiler.java:4967)<br/> 30: clojure.lang.Compiler$FnExpr.parse(Compiler.java:3588)<br/> 31: clojure.lang.Compiler.analyzeSeq(Compiler.java:6366)<br/> 32: clojure.lang.Compiler.analyze(Compiler.java:6175)<br/> 33: clojure.lang.Compiler.eval(Compiler.java:6421)<br/> 34: clojure.lang.Compiler.eval(Compiler.java:6390)<br/> 35: clojure.core$eval.invoke(core.clj:2795)<br/> 36: swank.commands.basic$eval_region.invoke(basic.clj:47)<br/> 37: swank.commands.basic$eval_region.invoke(basic.clj:37)<br/> 38: swank.commands.basic$eval764$listener_eval__765.invoke(basic.clj:71)<br/> 39: clojure.lang.Var.invoke(Var.java:401)<br/> 40: clojure.data.priority_map$eval2759.invoke(NO_SOURCE_FILE)<br/> 41: clojure.lang.Compiler.eval(Compiler.java:6424)<br/> 42: clojure.lang.Compiler.eval(Compiler.java:6390)<br/> 43: clojure.core$eval.invoke(core.clj:2795)<br/> 44: swank.core$eval_in_emacs_package.invoke(core.clj:92)<br/> 45: swank.core$eval_for_emacs.invoke(core.clj:239)<br/> 46: clojure.lang.Var.invoke(Var.java:409)<br/> 47: clojure.lang.AFn.applyToHelper(AFn.java:167)<br/> 48: clojure.lang.Var.applyTo(Var.java:518)<br/> 49: clojure.core$apply.invoke(core.clj:600)<br/> 50: swank.core$eval_from_control.invoke(core.clj:99)<br/> <span class="error">&#91;No Locals&#93;</span><br/> 51: swank.core$eval_loop.invoke(core.clj:104)<br/> 52: swank.core$spawn_repl_thread$fn_<em>529$fn</em>_530.invoke(core.clj:309)<br/> 53: clojure.lang.AFn.applyToHelper(AFn.java:159)<br/> 54: clojure.lang.AFn.applyTo(AFn.java:151)<br/> 55: clojure.core$apply.invoke(core.clj:600)<br/> 56: swank.core$spawn_repl_thread$fn__529.doInvoke(core.clj:306)<br/> 57: clojure.lang.RestFn.invoke(RestFn.java:397)<br/> 58: clojure.lang.AFn.run(AFn.java:24)<br/> 59: java.lang.Thread.run(Thread.java:680)</p> clojure-1.3.0-beta3 and git master, JDK 1.6.0_26, OS X 1.7.1 CLJ-837

java.lang.VerifyError when compiling deftype or defrecord with argument name starting with double underscore characters.

Defect Minor Closed Completed Fogus Tchavdar Roussanov Sun, 11 Sep 2011 19:05:10 -0500 Fri, 9 Dec 2011 10:01:00 -0600 Fri, 9 Dec 2011 10:01:00 -0600 Release 1.3 Release 1.4 1 2 <p>The privileged names __meta and __extmap are implementation details of types and records and should probably not be viewed as real. In other words, since they are not published as part of the type/record docs, then they may not exist in the future. Having said that, the current Clojure implementation treats any name starting with __ as a special field and doesn't count them toward the field count. As a result, when emitting the MyType.create method (another implementation detail), the fields marked as __ throw off the field count and as a result the bytecode is not emitted properly. I know how to change the code to allow names prefixed with __ and fixing the validation error (not called by those two special names listed above), but I hesitate to say that is the solution <br/> without further reflection.</p> <p>I think the prudent fix is as follows:</p> <ul> <li>Allow any legal name <b>except</b> those in the set #{__meta __extmap}</li> <li>Fix the #create emission</li> <li>Documentation should be changed to reflect that the aforementioned set is disallowed</li> </ul> <p>Thankfully this is an easy fix. However, the "magic" of __ prefixed names will go away. That is, the following behavior will differ from v1.2:</p> <div class="preformatted panel" style="border-width: 1px;"><div class="preformattedContent panelContent"> <pre>(defrecord R [__a ___b]) (:__a (R. 42 9)) ;=&gt; 42 (deftype T [__a]) (.__a (T. 36)) ;=&gt; 36 (deftype T2 [a b __meta]) ;; AssertionError </pre> </div></div> <p>Any thoughts?</p> <p>If anyone is interested, the changes reflected in the previous comment can be found on my own branch: <a href="https://github.com/fogus/clojure/tree/CLJ-837">https://github.com/fogus/clojure/tree/CLJ-837</a> Code-review would be nice.</p> <p>differing behavior of undocumented features is a non-problem</p> <p>Got it. Thanks Rich.</p> <p>Added patch file.</p> <p>I suggest that the documentation should simply say that all fields beginning with double-underscore (__) are reserved. You don't have to enforce that (as the patch allows any field name except __meta and __extmap), but it's better to be conservative with the documentation so that you have some room to innovate.</p> <p>Just by inspection, it looks like patch has an extra space before the 'b' in the line near the end:</p> <p>+ 2 (:___ b r)</p> <p>0837-fixed is same as original patch, but with fixed unit test.</p> Approval Ok Global Rank Patch Code and Test Waiting On richhickey