http://dev.clojure.org/jira This file is an XML representation of an issue en-us 4.4 649 25-07-2011 http://dev.clojure.org/jira/browse/CLJ-863 Clojure <p>interleave should handle 0 and 1 arguments in the same way that concat does (i.e., 0 args --&gt; empty seq, 1 args --&gt; identity).</p> CLJ-863

interleave should accept 1 or 0 arguments

Enhancement Trivial Open Unresolved Unassigned Joe Gallo Mon, 24 Oct 2011 14:50:34 -0500 Fri, 12 Apr 2013 10:03:08 -0500 Release 1.3 Release 1.6 5 1 <p>(lazy-seq nil) should be ()</p> <p>Hey Rich, if you're talking about the first line of the diff:</p> <p>+ ([] (lazy-seq nil))</p> <p>Then that's the implementation, not the tests &#8211; given an empty vector of arguments, return (lazy-seq nil), which I just copied from the existing definition of concat.</p> <p>Cheers,<br/> Joe</p> <p>(defn interleave <span class="error">&#91;&amp; s&#93;</span> (apply mapcat list s))</p> <p>Marc's definition doesn't work for no arguments. Maybe:</p> <p>(defn interleave <br/> ([] ()) <br/> (<span class="error">&#91;&amp; s&#93;</span> (apply mapcat list s)))</p> <p>Yes, but my solution is too slow, as it uses "apply".</p> <p>Patch clj-863-make-interleave-handle-odd-args-like-concat-patch-v1.txt dated Jan 1 2013 is identical to Joe Gallo's 0001-make-interleave-handle-odd-arugments-in-the-same-man.patch patch dated Oct 24 2011, except it returns () instead of (lazy-seq nil) as per Rich's comment. If concat should also return () instead of (lazy-seq nil), perhaps another ticket should be created to fix that. Also presumptuously changing ticket state from Incomplete back to Vetted, since the reason it was marked Incomplete should now be addressed, and it was Screened before.</p> Approval Ok Global Rank Patch Code and Test